Testing current behavior of if/then/else #11395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
4e6
approved these changes
Oct 24, 2024
Akirathan
approved these changes
Oct 24, 2024
engine/runtime-integration-tests/src/test/java/org/enso/compiler/test/IfThenElseTest.java
Outdated
Show resolved
Hide resolved
engine/runtime-integration-tests/src/test/java/org/enso/compiler/test/IfThenElseTest.java
Outdated
Show resolved
Hide resolved
JaroslavTulach
added
the
CI: Ready to merge
|
Expanded the list of tests to cover warnings. Also to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Related to #9165 work. Let's make sure the current behavior of
if/then/elseis properly tested by a unit test. Extracting test created as part of #11365 to verify it really describes the current behavior.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,