-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement hasLanguage interop message for all enso objects #11538
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
02e77fc
EnsoObject is an abstract class, not an interface.
Akirathan 3ab4f73
Implement public getters in BranchResult
Akirathan 5c5b0b7
Fix compilation of EnsoFile
Akirathan 0e48f21
Add test that all enso values must have language
Akirathan aa419c0
Revert EnsoException - remove
Akirathan b30f396
DataflowError and PanicException implement hasLanguage and getLanguage
Akirathan 613f380
DataflowError is not EnsoObject - change signatures in some builtins
Akirathan c5508db
Merge branch 'develop' into wip/akirathan/enso-object-abstract
Akirathan c682df0
Add more members to Module.isMemberInvocable.
Akirathan 993399a
Revert "DataflowError and PanicException implement hasLanguage and ge…
Akirathan 130180c
Update the test - test only non-primitive and non-exception values
Akirathan bea21a6
Fix indexes in CodeLocationsTest
Akirathan a59a72a
Add more members to Function.isMemberInvocable
Akirathan 1140546
EnsoObject.toDisplayString delegates to toString method
Akirathan 7fa2022
EnsoObject.toDisplayString is behind TruffleBoundary
Akirathan f0dae47
Warning exports InteropLibrary which delegates to value.
Akirathan 5955ff3
WithWarnings needs to explicitly export toDisplayString.
Akirathan db225ed
EnsoObject.toDisplayString just throws AssertionError
Akirathan 06d1d4c
AssertionError is behind TruffleBoundary
Akirathan 62aefe5
Implement toDisplayString on some truffle objects
Akirathan a06c672
Warning exports WarningsLibrary
Akirathan 9f33d74
Revert "Warning exports WarningsLibrary"
Akirathan 92722b8
Add some warnings test
Akirathan adb2d05
Warning.isNull is always false
Akirathan 9a79c84
Add some unnecessary methods to fix the compilation
Akirathan 46ebbd3
EnsoObject.toDisplayString is abstract
Akirathan 1c56a4c
ImportExportScope.toDisplayString is behind TruffleBoundary.
Akirathan 6dd7ac5
Hide some toDisplayString methods behind TruffleBoundary
Akirathan 965f999
Merge branch 'develop' into wip/akirathan/enso-object-abstract
Akirathan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you want to associate a language with
java.lang.Long
orjava.lang.Boolean
? What language you'd like to associate with such values? JavaScript? Enso?Language can only be associated with Enso objects - e.g. subtypes of
EnsoObject
!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Literal
42
in Enso is really not a literal, it is an atom of typeInteger
. So you can, e.g., call42.up_to 80 . each ...
. The same is true forTrue
, which is not the same asjava.lang.Boolean
. In the comment, I am talking about Enso "primitives" and not Java primitives.