Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intersection types & type checks #11600

Merged
merged 43 commits into from
Dec 12, 2024
Merged

Intersection types & type checks #11600

Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
c0c2fc5
Splitting types in EnsoMultiValue to methodDispatchTypes and the rest
JaroslavTulach Nov 20, 2024
c780c37
Merging with latest chances in develop
JaroslavTulach Nov 22, 2024
515e134
Don't expose EnsoMultiValue methods directly
JaroslavTulach Nov 25, 2024
d0460a4
TypeOf UnresolvedConstructor and UnresolvedSymbol test
JaroslavTulach Nov 25, 2024
a101fe6
Merge branch 'wip/jtulach/UseTypeOfNode11482' into wip/jtulach/Comple…
JaroslavTulach Nov 25, 2024
4e08d8f
UnsupportedMessageException.create accepts only AbstractTruffleException
JaroslavTulach Nov 25, 2024
acebbc1
Unwrap EnsoMultiValue before composing new EnsoMultiValue.create
JaroslavTulach Nov 25, 2024
af85b11
Avoid double wrapping test
JaroslavTulach Nov 25, 2024
ba5953f
Only consider booleans up to methodDispatchTypes
JaroslavTulach Nov 25, 2024
c2d1911
EqualsMultiValueTest
JaroslavTulach Nov 25, 2024
11f8ebc
Two unit tests showing a difference between success and failure
JaroslavTulach Nov 25, 2024
0278257
Special EqualsNode for EnsoMultiValue
JaroslavTulach Nov 25, 2024
720f644
Primitive interop types are mutually exclusive - we need to use one f…
JaroslavTulach Nov 25, 2024
ebaf492
Merge remote-tracking branch 'origin/develop' into wip/jtulach/Comple…
JaroslavTulach Nov 25, 2024
b5fc062
Interop value cannot be both isString and isNumber
JaroslavTulach Nov 25, 2024
02ec775
Handle EnsoMultiValue in a special way
JaroslavTulach Nov 25, 2024
57da6eb
Base EnsoMultiValue.equals on findAllTypesOrNull
JaroslavTulach Nov 26, 2024
3d048be
Documenting the example of Text and extra Integer equality check
JaroslavTulach Nov 26, 2024
be5dbe8
Don't consider extra multi value types in equals
JaroslavTulach Nov 26, 2024
0a81038
Note in the changelog
JaroslavTulach Nov 26, 2024
9fc4bb4
No need for StructsLibrary hack anymore
JaroslavTulach Nov 26, 2024
3a09a8d
No changes in GetFieldNode needed
JaroslavTulach Nov 26, 2024
20973d0
Intersection type and additional conversions tests
JaroslavTulach Nov 26, 2024
ce4c738
Verify dispatch of methods behaves as expected
JaroslavTulach Nov 27, 2024
a6ff51b
Only consider methodDispatchTypes for from conversions
JaroslavTulach Nov 27, 2024
957b3eb
Additional multi value tests
Akirathan Nov 29, 2024
dc490cf
Stream.of.anyMatch
JaroslavTulach Nov 29, 2024
d3102ad
Cleaning up allocated context
JaroslavTulach Nov 29, 2024
57eaf4a
Let converted by the variable name
JaroslavTulach Nov 29, 2024
9929fe8
Finishing documentation sentence
JaroslavTulach Nov 29, 2024
f5fbcf4
Otherwise extract value of type
JaroslavTulach Nov 29, 2024
ca0dd9a
Test also equality with Hi
JaroslavTulach Nov 29, 2024
2f72704
Send multi value as a method argument test
JaroslavTulach Dec 4, 2024
d1172a9
Merge remote-tracking branch 'origin/develop' into wip/jtulach/Comple…
JaroslavTulach Dec 10, 2024
f386c7b
All types state for type check nodes
JaroslavTulach Dec 10, 2024
7db299b
Documenting behavior of intersection types
JaroslavTulach Dec 11, 2024
1167b52
Documenting the converting type check
JaroslavTulach Dec 11, 2024
6b3b4d6
Example of failing conversions
JaroslavTulach Dec 11, 2024
52038f7
Verify case of on multi value
JaroslavTulach Dec 11, 2024
9eaa742
Note about #11600 in CHANGELOG.md belongs to Next Next Release
JaroslavTulach Dec 11, 2024
d1cbc8d
Radek's comments to Intersection Types documentation
radeusgd Dec 12, 2024
77619ab
Open to subclasses
JaroslavTulach Dec 12, 2024
91987ca
Multi value == is not transitive
JaroslavTulach Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions test/Base_Tests/src/Semantic/Multi_Value_Convert_Spec.enso
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,34 @@ add_specs suite_builder =
Test.expect_panic Type_Error <| ac:U
ac:V . v . should_equal 3.14

group_builder.specify "case of first" <|
abc = 3.14 : A&B&C
c1 = case abc of
a:A -> a.a
b:B -> b.b
c:C -> c.c
_ -> "what?"
c1 . should_equal "a"

group_builder.specify "case of second downcasted" <|
abc = 3.14 : A&B&C
c1 = case abc:B of
b:B -> b.b
a:A -> a.a
c:C -> c.c
_ -> "what?"
c1 . should_equal "b"

group_builder.specify "case of third downcasted" <|
abc = 3.14 : A&B&C
c1 = case abc:C of
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pattern matching on type on first value of a EnsoMultiValue works, but we want to match on other values as well:

diff --git test/Base_Tests/src/Semantic/Multi_Value_Convert_Spec.enso test/Base_Tests/src/Semantic/Multi_Value_Convert_Spec.enso
index ca768daaa0..2e54642532 100644
--- test/Base_Tests/src/Semantic/Multi_Value_Convert_Spec.enso
+++ test/Base_Tests/src/Semantic/Multi_Value_Convert_Spec.enso
@@ -84,6 +84,41 @@ add_specs suite_builder =
                 _ -> "what?"
             c1 . should_equal "c"
 
+        group_builder.specify "case of second" <|
+            abc = 3.14 : A&B&C
+            c1 = case abc of
+                b:B -> b.b
+                a:A -> a.a
+                c:C -> c.c
+                _ -> "what?"
+            c1 . should_equal "b"
+
+        group_builder.specify "case of third" <|
+            abc = 3.14 : A&B&C
+            c1 = case abc of
+                c:C -> c.c
+                b:B -> b.b
+                a:A -> a.a
+                _ -> "what?"
+            c1 . should_equal "c"
+
+        group_builder.specify "case of second from extra types" <|
+            abc = 3.14 : A&B&C
+            c1 = case abc:A of
+                b:B -> b.b
+                a:A -> a.a
+                c:C -> c.c
+                _ -> "what?"
+            c1 . should_equal "b"
+
+        group_builder.specify "case of third  from extra types" <|
+            abc = 3.14 : A&B&C
+            c1 = case abc:A of
+                c:C -> c.c
+                b:B -> b.b
+                a:A -> a.a
+                _ -> "what?"
+            c1 . should_equal "c"
 
 main filter=Nothing =
     suite = Test.build suite_builder->

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests look great

c:C -> c.c
b:B -> b.b
a:A -> a.a
_ -> "what?"
c1 . should_equal "c"


main filter=Nothing =
suite = Test.build suite_builder->
add_specs suite_builder
Expand Down
Loading