-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort output of File.list
#11752
Sort output of File.list
#11752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving sort
from Data.list
into File.list
makes Data.list
sorted only when listing local directories, but not S3 nor Cloud.
Please, either bring it back onto Data.list
or ensure that the sort is added to other backends.
My rationale for doing it on Data.list
was that this was the user facing method and the more internal (S3_|Enso_|)File.list
was a bit more low level and used in our internals so the overhead of sorting was not needed there. But perhaps it's good to just keep them consistent - so we probably want to sort everywhere.
@radeusgd I have put sort back in |
Hmm, but why do it this way? This way we are still inconsistent - we sort in I guess sorting in all backends is the way to go. |
Sounds good. I've created #11899 for this, since this change needs to go into the release. |
Closes #11669.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.