Edit text for "delete asset" modal #11857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
added
CI: No changelog needed
somebody1234
requested review from
PabloBuchu,
indiv0,
MrFlashAccount,
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
somebody1234
force-pushed
the
wip/sb/fix-confirm-delete-text
branch
from
d166e01 to
d00282a
Compare
MrFlashAccount
approved these changes
Dec 13, 2024
PabloBuchu
reviewed
Dec 13, 2024
|
@somebody1234 1. |
|
@somebody1234 is it ready for QA? the |
|
@PabloBuchu nice catch... thanks. should be fixed now |
| @@ -54,3 +55,36 @@ test('delete and restore (keyboard)', ({ page }) => | |||
| .driveTable.withRows(async (rows) => { | |||
| await expect(rows).toHaveCount(1) | |||
| })) | |||
|
|
|||
| test('clear trash', ({ page }) => | |||
| mockAllAndLogin({ page }) | |||
There was a problem hiding this comment.
Maybe we can just setup the folders/projects using setupAPI here? This is faster and creating assets already tested in the other tests
There was a problem hiding this comment.
forgor! nice catch
MrFlashAccount
approved these changes
Dec 31, 2024
PabloBuchu
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
None
Testing Instructions
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.~~~
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.