Fix missing placeholders #11894
Merged
Fix missing placeholders #11894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show placeholder for any argument that doesn't have a default value, including collapsed function args. Cf. #11347.
kazcw
added
the
CI: No changelog needed
🧪 Storybook is successfully deployed!📊 Dashboard:
|
kazcw
requested review from
Frizi,
farmaazon,
vitvakatu and
AdRiley
as code owners
farmaazon
approved these changes
Dec 18, 2024
kazcw
changed the base branch from
develop
to
wip/farmaazon/fix-select-after-delete
Base automatically changed from
wip/farmaazon/fix-select-after-delete
to
develop
January 2, 2025 11:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Show placeholder for any argument that doesn't have a default value, including collapsed function args; add integration test for collapsed function arg placeholders.
Fixes #11347.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.