Use MPLUS 1 font #11904
Merged
Use MPLUS 1 font #11904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
requested review from
Frizi,
farmaazon,
kazcw and
AdRiley
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
Frizi
approved these changes
Dec 18, 2024
|
Well, I think on linux, even with fractional scaling it looks same:
So if Windows with fractional scaling also works, I think it's good to go. I don't know what exactly were the previous issues with MPLUS1... |
vitvakatu
added
CI: Ready to merge
Frizi
pushed a commit
that referenced
this pull request
Dec 30, 2024
Closes #10692 I don’t see any significant changes compared to Enso font: MPLUS 1: https://github.com/user-attachments/assets/17890f6a-0c4f-4aa5-9b4e-d9bd318fd625 Enso Font: https://github.com/user-attachments/assets/5f476dc8-84c0-4855-8d5b-9d21a7c93b1d # Important Notes ~~**I didn’t test if it actually fixes the issue with clipping on Windows, waiting for CI build.**~~ Tested on Windows, the issue is not visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #10692
I don’t see any significant changes compared to Enso font:
MPLUS 1:
mplus1-font.mp4
Enso Font:
enso-font.mp4
Important Notes
I didn’t test if it actually fixes the issue with clipping on Windows, waiting for CI build.Tested on Windows, the issue is not visible.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.