Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required checks #11919

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Update required checks #11919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf0ce0a
update: required checks
4e6 Dec 19, 2024
7275e38
update: rename GUI Packaging to IDE
4e6 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/engine-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
secrets: inherit

required-checks:
name: Required Checks
name: Engine Required Checks
runs-on: ubuntu-latest
needs: [engine-checks]
if: always()
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gui-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
secrets: inherit

required-checks:
name: Required Checks
name: GUI Required Checks
runs-on: ubuntu-latest
needs: [prettier, gui-checks, storybook]
if: always()
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/gui-packaging-optional.yml → .github/workflows/ide-packaging-optional.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This file is auto-generated. Do not edit it manually!
# Edit the enso_build::ci_gen module instead and run `cargo run --package enso-build-ci-gen`.

name: GUI Packaging (Optional)
name: IDE Packaging (Optional)
on:
workflow_dispatch:
inputs:
Expand All @@ -12,7 +12,7 @@ on:
default: false
workflow_call: {}
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-gui-packaging-optional
group: ${{ github.workflow }}-${{ github.ref }}-ide-packaging-optional
cancel-in-progress: ${{ github.ref != 'refs/heads/develop' }}
jobs:
enso-build-ci-gen-job-build-backend-macos-amd64:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/gui-packaging.yml → .github/workflows/ide-packaging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This file is auto-generated. Do not edit it manually!
# Edit the enso_build::ci_gen module instead and run `cargo run --package enso-build-ci-gen`.

name: GUI Packaging
name: IDE Packaging
on:
workflow_dispatch:
inputs:
Expand All @@ -12,7 +12,7 @@ on:
default: false
workflow_call: {}
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-gui-packaging
group: ${{ github.workflow }}-${{ github.ref }}-ide-packaging
cancel-in-progress: ${{ github.ref != 'refs/heads/develop' }}
jobs:
enso-build-ci-gen-job-build-backend-linux-amd64:
Expand Down
20 changes: 10 additions & 10 deletions .../workflows/gui-packaging-pull-request.yml → .github/workflows/ide-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This file is not auto-generated. Feel free to edit it.

name: ✨ GUI Packaging
name: ✨ IDE

on:
push:
Expand All @@ -9,7 +9,7 @@ on:
pull_request:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-gui-packaging-pull-request
group: ${{ github.workflow }}-${{ github.ref }}-ide-pull-request
cancel-in-progress: ${{ github.ref != 'refs/heads/develop' }}

jobs:
Expand All @@ -23,31 +23,31 @@ jobs:
uses: ./.github/workflows/engine-changed-files.yml
secrets: inherit

gui-packaging:
ide-packaging:
name: 📦 Package
uses: ./.github/workflows/gui-packaging.yml
uses: ./.github/workflows/ide-packaging.yml
needs: [gui-changed-files, engine-changed-files]
if: needs.gui-changed-files.outputs.any_changed == 'true' || needs.engine-changed-files.outputs.any_changed == 'true' || github.ref == 'refs/heads/develop'
secrets: inherit

gui-packaging-optional:
ide-packaging-optional:
name: 📦 Package (Optional)
uses: ./.github/workflows/gui-packaging-optional.yml
uses: ./.github/workflows/ide-packaging-optional.yml
needs: [gui-changed-files, engine-changed-files]
if: needs.gui-changed-files.outputs.any_changed == 'true' || needs.engine-changed-files.outputs.any_changed == 'true' || github.ref == 'refs/heads/develop'
secrets: inherit

required-checks:
name: Required Checks
name: IDE Required Checks
runs-on: ubuntu-latest
needs: [gui-packaging]
needs: [ide-packaging]
if: always()
steps:
- name: Checks Summary
run: |
echo "GUI Packaging: ${{ needs.gui-packaging.result }}"
echo "IDE: ${{ needs.ide-packaging.result }}"

if [[ "${{ needs.gui-packaging.result }}" == "failure" ]]; then
if [[ "${{ needs.ide-packaging.result }}" == "failure" ]]; then
exit 1
fi

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/wasm-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
secrets: inherit

required-checks:
name: Required Checks
name: WASM Required Checks
runs-on: ubuntu-latest
needs: [wasm-checks]
if: always()
Expand Down
4 changes: 2 additions & 2 deletions build/build/paths.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
engine-checks-optional.yml:
engine-checks.yml:
extra-nightly-tests.yml:
gui-packaging-optional.yml:
gui-packaging.yml:
ide-packaging-optional.yml:
ide-packaging.yml:
nightly.yml:
promote.yml:
release.yml:
Expand Down
16 changes: 8 additions & 8 deletions build/build/src/ci_gen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,15 +687,15 @@ pub fn typical_check_triggers() -> Event {
}
}

pub fn gui_packaging() -> Result<Workflow> {
pub fn ide_packaging() -> Result<Workflow> {
let on = Event {
workflow_dispatch: Some(manual_workflow_dispatch()),
workflow_call: Some(default()),
..default()
};
let mut workflow = Workflow {
name: "GUI Packaging".into(),
concurrency: Some(concurrency("gui-packaging")),
name: "IDE Packaging".into(),
concurrency: Some(concurrency("ide-packaging")),
on,
..default()
};
Expand All @@ -710,15 +710,15 @@ pub fn gui_packaging() -> Result<Workflow> {
Ok(workflow)
}

pub fn gui_packaging_optional() -> Result<Workflow> {
pub fn ide_packaging_optional() -> Result<Workflow> {
let on = Event {
workflow_dispatch: Some(manual_workflow_dispatch()),
workflow_call: Some(default()),
..default()
};
let mut workflow = Workflow {
name: "GUI Packaging (Optional)".into(),
concurrency: Some(concurrency("gui-packaging-optional")),
name: "IDE Packaging (Optional)".into(),
concurrency: Some(concurrency("ide-packaging-optional")),
on,
..default()
};
Expand Down Expand Up @@ -906,8 +906,8 @@ pub fn generate(
(repo_root.engine_checks_optional_yml.to_path_buf(), engine_checks_optional()?),
(repo_root.engine_checks_nightly_yml.to_path_buf(), engine_checks_nightly()?),
(repo_root.extra_nightly_tests_yml.to_path_buf(), extra_nightly_tests()?),
(repo_root.gui_packaging_yml.to_path_buf(), gui_packaging()?),
(repo_root.gui_packaging_optional_yml.to_path_buf(), gui_packaging_optional()?),
(repo_root.ide_packaging_yml.to_path_buf(), ide_packaging()?),
(repo_root.ide_packaging_optional_yml.to_path_buf(), ide_packaging_optional()?),
(repo_root.wasm_checks_yml.to_path_buf(), wasm_checks()?),
(repo_root.engine_benchmark_yml.to_path_buf(), engine_benchmark()?),
(repo_root.std_libs_benchmark_yml.to_path_buf(), std_libs_benchmark()?),
Expand Down
Loading