-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification tray for displaying in-flight requests #12078
Open
somebody1234
wants to merge
91
commits into
develop
Choose a base branch
from
wip/sb/loader-for-requests
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
91 commits
Select commit
Hold shift + click to select a range
8f98f4b
WIP
somebody1234 831341a
WIP: Initial implementation of transient notifications and notificati…
somebody1234 bf3dcae
WIP: Fix bugs
somebody1234 ac5a637
WIP
somebody1234 c4adc48
WIP: Debugging
somebody1234 1abd286
Remove unused dependency
somebody1234 5ea4c12
Add support for colors in `NotificationItem`
somebody1234 2c0fd30
help
somebody1234 4670466
WIP: Fix RAC error
somebody1234 23f4ffb
Fix issue with `GridList` crashing entire app
somebody1234 fd48790
Remove testing notification
somebody1234 5a764d1
Remove inaccurate notification count as mutations are batched
somebody1234 be00166
Implement notification for file uploads progress
somebody1234 c7bce7f
Merge branch 'develop' into wip/sb/loader-for-requests
somebody1234 79e556e
Fix Bazel on NixOS
somebody1234 a54aa72
Fix Bazel build
somebody1234 0406785
Initial UI for file upload notification
somebody1234 3311cd5
WIP: Make computed notifications permanent
somebody1234 12198bd
Merge branch 'develop' into wip/sb/loader-for-requests
somebody1234 1f6ad21
Make notifications persistent
somebody1234 97516df
Fix user bar styling
somebody1234 9ebacc6
Omit special assets from being selected
somebody1234 951abc7
Fix notification display
somebody1234 d37123b
Add timestamp to notifications
somebody1234 f75f803
Show timestamp in notification entry
somebody1234 127473a
Add button to Devtools to clear TanStack query cache and reload
somebody1234 d112658
Show red indicator on unread notifications; fix notification display;…
somebody1234 e13a547
pnpm i
somebody1234 b426bc7
Fix errors
somebody1234 b063193
Fix infinite loop when uploading file
somebody1234 e3951d9
Support indeterminate progress state for notifications
somebody1234 a775770
Disable dropzone in Trash and Recent categories
somebody1234 e5a207c
WIP: Fix "confirm delete" modal
somebody1234 161685f
Actually stop "confirm delete" modal from closing early when deleting…
somebody1234 08d3a2e
Add close button to notifications
somebody1234 14f4490
Switch `NotificationItem` to use `tailwind-variants`
somebody1234 8e11365
Use icon instead of button for notification icon
somebody1234 74f5c10
WIP: Show toast for some notifications
somebody1234 e4410b5
Fix crash
somebody1234 d99695b
Fix notification toasts
somebody1234 9a23d58
Remove `useUploadFileWithToastMutation` because notifications now upd…
somebody1234 25aa2f3
Distinguish hard delete and soft delete in notifications
somebody1234 a9eeba0
Fix detection for whether a notification is finished
somebody1234 d6d7718
Fix notification toast display and autoclose
somebody1234 a458cac
Fix layout of close button for notifications
somebody1234 b23f600
`ProgressBar` component
somebody1234 747dfc5
UI for indeterminate progress bar state
somebody1234 e09557e
Merge branch 'develop' into wip/sb/loader-for-requests
somebody1234 f7f4f41
Only show notifications for uploads by default
somebody1234 75116a3
Use central icon for inbox
somebody1234 1a3b488
Remove `color` prop from `Button` component
somebody1234 f2765a0
Merge branch 'develop' into wip/sb/loader-for-requests
somebody1234 1fc2be3
Clean up finished computed notification 1 minute after action finishes
somebody1234 cfa1fe4
Add and use `StatusBadge` component
somebody1234 df64295
Add stories for `ProgressBar`
somebody1234 22e967d
Add stories for `StatusBadge`
somebody1234 58d7a2b
Merge branch 'develop' into wip/sb/loader-for-requests
somebody1234 73e54bd
Merge branch 'develop' into wip/sb/loader-for-requests
somebody1234 99e1040
[ts] Fix type errors
somebody1234 0ad29b2
[ts] Fix lint errors
somebody1234 ffbd63d
[dashboard] Fix integration tests?
somebody1234 258f83d
Merge branch 'develop' into wip/sb/loader-for-requests
somebody1234 30553f0
Merge branch 'develop' into wip/sb/loader-for-requests
somebody1234 b78fb5f
[dashboard/DashboardTabBar] Fix background opacity
somebody1234 45bbfef
[dashboard/NotificationTray] Move to new folder
somebody1234 c2d82f8
[dashboard/computedNotificationHooks] Address CR
somebody1234 1d62760
[dashboard] Use `variants` prop instead of `_STYLES` constants directly
somebody1234 df79b1e
[dashboard/ProgressBar] Improve storybook
somebody1234 046352d
[dashboard/NotificationItem] Add storybook
somebody1234 eab2aa3
[dashboard/NotificationItem] Improve storybook
somebody1234 9b87099
[dashboard/Icon] Improve storybook
somebody1234 0964796
[dashboard/Breadcrumbs] Rename storybook stories
somebody1234 1005cec
[dashboard/Text] Improve storybook
somebody1234 7d06765
[dashboard/Text] Add `StoryVariants` component
somebody1234 4dcc6ab
[dashboard/ProgressBar] Use `StoryVariants`
somebody1234 cf1c192
[dashboard/Icon] Use `StoryVariants`
somebody1234 cc37b11
[dashboard/NotificationItem] Improve type safety in stories
somebody1234 8522ff3
[dashboard/Button] Fix type error in stories
somebody1234 00acf20
[dashboard/Check] Use `StoryVariants`
somebody1234 23e4e3f
[dashboard/Button] Use `StoryVariants`
somebody1234 7bfd64d
[dashboard/StatusBadge] Use `StoryVariants`
somebody1234 b668fa2
[dashboard/ComboBox] Use `StoryVariants`
somebody1234 5b203d3
[dashboard/DatePicker] Use `StoryVariants`
somebody1234 755621e
[dashboard/Selector] Use `StoryVariants`
somebody1234 6fa42fb
[dashboard/computedNotificationHooks] Fix type error
somebody1234 2c97e30
[dashboard/Category] Add `canUploadHere` field for drag and drop
somebody1234 bf3e46e
[dashboard/NotificationItem] Fix type error in stories
somebody1234 89c2207
[dashboard/Button] Prettier
somebody1234 c19a7c0
[dashboard/LocalStorage] Fix type errors
somebody1234 3bc14b5
[dashboard/LocalStorage] Fix type errors
somebody1234 17e4c94
[dashboard/LocalStorage] will this make lints pass?
somebody1234 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove it