Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Discovery button #12081

Merged
merged 4 commits into from
Mar 4, 2025
Merged

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Jan 20, 2025

Pull Request Description

Closes: https://github.com/enso-org/cloud-v2/issues/1700

Should be merged after #12299

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

Copy link

github-actions bot commented Jan 20, 2025

🧪 Storybook is successfully deployed!

📊 Dashboard:

@PabloBuchu
Copy link
Contributor

So we are disabling discovery until we deliver either samples as a part of user space or some other way of getting project templates? whats the reasoning here?

@MrFlashAccount
Copy link
Contributor Author

This is a sub-step of simplifying the revised Project rework. This pull request does not make sense without relocating the Help section to the topbar and integrating samples into the assets tree. Therefore, this pull request can be merged after these modifications have been implemented.

@MrFlashAccount MrFlashAccount self-assigned this Jan 21, 2025
@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. CI: Keep up to date Automatically update this PR to the latest develop. g-dashboard and removed CI: Keep up to date Automatically update this PR to the latest develop. labels Jan 21, 2025
@MrFlashAccount MrFlashAccount marked this pull request as draft January 22, 2025 10:42
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/hide-discovery-button branch from 8992761 to b7300c9 Compare March 4, 2025 09:57
@MrFlashAccount MrFlashAccount changed the title Hide Discovery button Remove Discovery button Mar 4, 2025
@MrFlashAccount MrFlashAccount marked this pull request as ready for review March 4, 2025 10:03
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

@PabloBuchu PabloBuchu added the CI: Ready to merge This PR is eligible for automatic merge label Mar 4, 2025
@mergify mergify bot merged commit cb728d0 into develop Mar 4, 2025
60 of 63 checks passed
@mergify mergify bot deleted the wip/sergeigarin/hide-discovery-button branch March 4, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants