Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing builtin methods from Any #12155

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

JaroslavTulach
Copy link
Member

Pull Request Description

Yet closer to #5226. Cleanup of Any to not contain builtins itself.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • Unit continue to pass

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 27, 2025
@JaroslavTulach JaroslavTulach self-assigned this Jan 27, 2025
@JaroslavTulach JaroslavTulach marked this pull request as draft January 27, 2025 19:16
@JaroslavTulach
Copy link
Member Author

I am afraid this PR needs to be put on hold until we do something with

There are failures in the CI tests caused by the fact that Any.to_text or Any.== isn't available. Solutions:

Opinions?

@enso-bot enso-bot bot mentioned this pull request Jan 28, 2025
@Akirathan
Copy link
Member

Opinions?

Since this PR is basically a refactoring PR that is not needed for anything important (right?), I would rather wait for the prelude solution, than inserting from Standard.Base import Any to the failing tests.

@JaroslavTulach
Copy link
Member Author

Opinions?

Since this PR is basically a refactoring PR that is not needed for anything important (right?), I would rather wait for the prelude solution, than inserting from Standard.Base import Any to the failing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants