Fix Native Image search path on Windows #12356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fallback mechanism had a hardcoded `enso` executable name instead of using an OS-specific one. Hence, lack of NI support on Windows.
hubertp
added
the
CI: No changelog needed
hubertp
requested review from
4e6,
JaroslavTulach and
Akirathan
as code owners
Akirathan
approved these changes
Feb 25, 2025
4e6
approved these changes
Feb 25, 2025
JaroslavTulach
approved these changes
Feb 25, 2025
engine/language-server/src/main/scala/org/enso/languageserver/boot/MainModule.scala
Outdated
Show resolved
Hide resolved
…boot/MainModule.scala Co-authored-by: Jaroslav Tulach <[email protected]>
2 tasks
|
Hubert Plociniczak reports a new STANDUP for the provided date (2025-02-25): Progress: Identified problem with NI on Windows, PR pending. Looking into various logging issues. It should be finished by 2025-02-25. Next Day: Next day I will be working on the #12356 task. Address review, pick up next items. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fallback mechanism had a hardcoded
ensoexecutable name instead of using an OS-specific one. Hence, lack of NI support on Windows.Important Notes
Follow up on #12287.