Ensure project-manager's logs are centrally collected #12361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor fix to bring back project-manager's logs. Previous, default, configuration meant that logs for project-manager ended up in a separate file from the rest of the logs. Language server logs are being sent to the logging server by default, so should project-manager's ones as well. Fixed NPE in `SocketLoggingNode` when no `project.id` is present in loggers, as is the case with logs coming from project-manager.
hubertp
added
the
CI: No changelog needed
hubertp
requested review from
4e6,
JaroslavTulach and
Akirathan
as code owners
4e6
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Minor fix to bring back project-manager's logs.
Previous, default, configuration meant that logs for project-manager ended up in a separate file from the rest of the logs. Language server logs are being sent to the logging server by default, so should project-manager's ones as well.
Fixed NPE in
SocketLoggingNodewhen noproject.idis present in loggers, as is the case with logs coming from project-manager.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.