Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speculate on no interrupt in WithInterruptHandlerNode #12364

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Speculate on no interrupt in WithInterruptHandlerNode #12364

merged 1 commit into from
Feb 27, 2025

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Feb 25, 2025 •
edited
Loading

Pull Request Description

It is not that common for an interrupt to occur. Speculate its handling branch doesn't need to be compiled in.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • Unit tests continue to work

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 25, 2025
@JaroslavTulach JaroslavTulach self-assigned this Feb 25, 2025
@JaroslavTulach JaroslavTulach changed the title Speculate on no interrupt Speculate on no interrupt in WithInterruptHandlerNode Feb 25, 2025
@enso-bot enso-bot bot mentioned this pull request Feb 26, 2025
Closed
Akirathan
Akirathan approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to run (at least some) engine benchmarks. Would love to see how (or if at all) the performance changes.

@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Feb 27, 2025
@mergify mergify bot merged commit d395b75 into develop Feb 27, 2025
73 of 74 checks passed
@mergify mergify bot deleted the wip/jtulach/SpeculateNoInterrupt branch February 27, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akirathan Akirathan Akirathan approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaroslavTulach @Akirathan