-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Component Browser with Groups panel #12386
Conversation
Looks good! Couple of things I spotted:
|
app/gui/src/project-view/components/ComponentBrowser/ComponentList.vue
Outdated
Show resolved
Hide resolved
app/gui/src/project-view/components/ComponentBrowser/ComponentList.vue
Outdated
Show resolved
Hide resolved
🧪 Storybook is successfully deployed!📊 Dashboard:
|
app/gui/src/project-view/components/ComponentBrowser/ComponentList.vue
Outdated
Show resolved
Hide resolved
IMO looks perfect, proper paddings around |
On my side - text isn't aligned with icons properly, better move 3px up On dashboard we spent a couple of time to make our font look pixel-perfect: https://github.com/enso-org/enso/blob/develop/app/gui/src/dashboard/components/AriaComponents/Text/Text.tsx#L55-L56 Please refer to figma for exact numbers: Note, that on windows this font looks much better and we can set paddings to 2px |
As this is more "global" problem (the misalignment seems to be coming from the font itself), I would make it in a separate PR, as this looks like a significant time for little effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR ✅ for single line change in ide-desktop
Pull Request Description
Fixes #12309
Fixes #12327
Screencast.From.2025-02-28.15-07-45.mp4
Important Notes
The list of components was refactored out to
LazyList
- this list instantiates HTML elements only of visible things. I'm not sure about the name - is there any more "technical" term for such a list?Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.