Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Component Browser with Groups panel #12386

Merged
merged 20 commits into from
Mar 5, 2025
Merged

Conversation

farmaazon
Copy link
Contributor

@farmaazon farmaazon commented Feb 28, 2025

Pull Request Description

Fixes #12309
Fixes #12327

Screencast.From.2025-02-28.15-07-45.mp4

Important Notes

The list of components was refactored out to LazyList - this list instantiates HTML elements only of visible things. I'm not sure about the name - is there any more "technical" term for such a list?

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@AdRiley
Copy link
Member

AdRiley commented Feb 28, 2025

Looks good! Couple of things I spotted:

  1. Can we add a > on the right side of the selected group?
  2. With the delay on the group changing it needs to work if I cross another group as I reach for a component.

@AdRiley
Copy link
Member

AdRiley commented Feb 28, 2025

Nit but this horizontal gap is perhaps a little big?
image

@farmaazon farmaazon requested a review from kazcw March 3, 2025 14:15
Copy link

github-actions bot commented Mar 3, 2025

🧪 Storybook is successfully deployed!

📊 Dashboard:

@farmaazon
Copy link
Contributor Author

With arrow:

image

@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Mar 4, 2025
@farmaazon farmaazon removed the CI: Ready to merge This PR is eligible for automatic merge label Mar 4, 2025
@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Mar 4, 2025
@MrFlashAccount
Copy link
Contributor

@AdRiley

Nit but this horizontal gap is perhaps a little big?

IMO looks perfect, proper paddings around

@MrFlashAccount
Copy link
Contributor

MrFlashAccount commented Mar 5, 2025

On my side - text isn't aligned with icons properly, better move 3px up

On dashboard we spent a couple of time to make our font look pixel-perfect: https://github.com/enso-org/enso/blob/develop/app/gui/src/dashboard/components/AriaComponents/Text/Text.tsx#L55-L56

Please refer to figma for exact numbers:
CleanShot 2025-03-05 at 11 15 55@2x

Note, that on windows this font looks much better and we can set paddings to 2px

@farmaazon
Copy link
Contributor Author

On my side - text isn't aligned with icons properly, better move 3px up

As this is more "global" problem (the misalignment seems to be coming from the font itself), I would make it in a separate PR, as this looks like a significant time for little effect.

Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅ for single line change in ide-desktop

@mergify mergify bot merged commit da89ff6 into develop Mar 5, 2025
59 of 62 checks passed
@mergify mergify bot deleted the wip/farmaazon/cb-group-panel branch March 5, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CB Improvements - Searching with groups CB Improvements - Group list
5 participants