-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflection configuration for AWS #12394
Conversation
Fixing missing configuration for supporting AWS in native-image. Not yet complete, as NI has issues with Builder pattern.
Moving some polyglot calls to a util class so that we can workaround (what appears to be) a bug in native image. With this change, AWS tests pass (with appropriate authentication).
polyglot java import software.amazon.awssdk.services.s3.model.DeleteObjectRequest | ||
polyglot java import software.amazon.awssdk.services.s3.model.GetObjectRequest | ||
polyglot java import software.amazon.awssdk.services.s3.model.HeadBucketRequest | ||
polyglot java import software.amazon.awssdk.services.s3.model.HeadObjectRequest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing all these imports with S3Util is good from code perspective, generated image size, maintainability & co. We should use this “wrapper model” more in other “polyglot Java import” cases.
public class S3Utils { | ||
private S3Utils() {} | ||
|
||
public static DeleteObjectRequest delete_object_request(String bucket, String key) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice wrappers
Hubert Plociniczak reports a new STANDUP for the provided date (2025-03-01): Progress: Investigating native image issue with AWS. Debugging performance regression when running engine test suite. It should be finished by 2025-03-04. Next Day: Next day I will be working on the #12394 task. Continue investigating NI issues. |
Hubert Plociniczak reports a new STANDUP for the provided date (2025-03-03): Progress: Fixed issues with Standard.AWS on native image. Had to workaround some limitations by providing a facade for some of library calls. It should be finished by 2025-03-04. Next Day: Next day I will be working on the #12394 task. Continue investigating test suite perf degradation. |
Pull Request Description
Fixing missing configuration for supporting AWS in native-image. Not yet complete, as NI has issues with Builder pattern.
Also fixes
atInfo
crash regression that has been introduced by changes in #12163.Important note
There appears to a bug in reflection configuration in Native Image because it would continue to report (among many others)
failures despite an appropriate entry being present in
reflect-config.json
. We should probably report it to Graal.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.