Fix Drive table #12397

somebody1234 · 2025-03-03T08:18:31Z

Pull Request Description

Add background to "hidden columns" menu in the top right of the Drive table
Fix arrows being on separate line on "name" and "modified" columns in Drive table

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

~~The documentation has been updated, if necessary.~~
~~Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.~~
All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
~~Unit tests have been written where possible.~~
If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
or the Snowflake database integration, a run of the Extra Tests has been scheduled.
- ~~If applicable, it is suggested to paste a link to a successful run of the Extra Tests.~~

github-actions · 2025-03-03T08:32:31Z

🧪 Storybook is successfully deployed!

📊 Dashboard:

👀 Review changes: https://www.chromatic.com/build?appId=673738989fc3e8430364197e&number=1658
👨‍🎨 Preview storybook: https://673738989fc3e8430364197e-veqlnqqwgm.chromatic.com/

…directory

…" calls and replace with `refetchInterval` when necessary

PabloBuchu · 2025-03-03T09:44:25Z

Something is still broken with the scroll bar

app/gui/src/dashboard/components/AriaComponents/Button/Button.tsx

app/gui/src/dashboard/components/Breadcrumbs/Breadcrumbs.tsx

app/gui/src/dashboard/components/dashboard/columnHeading/ModifiedColumnHeading.tsx

… Log" settings page)

MrFlashAccount · 2025-03-03T11:41:02Z

app/gui/src/dashboard/components/AriaComponents/Button/Button.tsx

@@ -337,7 +337,7 @@ const ButtonContent = memo(function ButtonContent(props: ButtonContentProps) {
        styles={styles}
        hideLoader={hideLoader}
      />
-      <Text color="inherit" truncate="1" className={styles.text()}>
+      <Text weight="custom" color="inherit" truncate="1" className={styles.text()}>


On the second though - why did we add the <Text /> component here?

oh right. mainly so I could get ellipsis + hover tooltip when the timezone is too long:

... granted, that should not be a button since it is not interactable, I am just using it as a hack to have an icon and text that are (or are supposed to be) pre-aligned

any better suggestions?

Buttons (actions) shouldn't be truncated and should use active verbs. What does this button do?

uhh... nothing 😅 - as above, just using it as a hack to get a pre-aligned icon + text combo. i guess ideally we could refactor this out to a style-only component and then use that instead of a full on Button...

either way Text has been refactored away from Button again anyway

Yeah, lets use just a <Text /> element instead of button here.

i guess ideally we could refactor this out to a style-only component

Yeah, we can add this pattern as a pattern (https://panda-css.com/docs/concepts/patterns) using tv function.

Also we do the same here so we can base the receipt on this: https://github.com/enso-org/enso/blob/wip/sergeigarin/flat-folder-structure-follow-up/app/gui/src/dashboard/components/Breadcrumbs/BreadcrumbItem.tsx#L206

…ttier plugin to allow automatically removing unused imports

…n this month

…n execution info

MrFlashAccount · 2025-03-05T10:27:43Z

app/gui/src/dashboard/components/AriaComponents/Button/Button.tsx

@@ -337,9 +337,7 @@ const ButtonContent = memo(function ButtonContent(props: ButtonContentProps) {
        styles={styles}
        hideLoader={hideLoader}
      />
-      <Text color="inherit" truncate="1" className={styles.text()}>


We used to have a span with className={styles.text()}, haven't we?

well, i tried extracting the css directly and it doesn't seem to work.
try running this commit in dev (staging env) and create a project execution (no repeats to minimize load, but long timezone to (try to) trigger the truncate class):

438c4f3

MrFlashAccount · 2025-03-05T10:29:11Z

app/gui/src/dashboard/components/AriaComponents/IconDisplay/IconDisplay.tsx

+}
+
+/** A text display with an icon. */
+export function IconDisplay<IconType extends string>(props: IconDisplayProps<IconType>) {


when I told about patterns I meant only the ICON_DISPLAY_STYLES part,

i guess, but i do want a dedicated component to avoid having to rewrite the markup (and get it right) every time, unless you have a better idea

MrFlashAccount · 2025-03-05T10:30:32Z

app/gui/src/dashboard/components/AriaComponents/Text/Text.tsx

-      '8': 'line-clamp-8 ellipsis',
-      '9': 'line-clamp-9 ellipsis',
-      custom: 'line-clamp-[var(--line-clamp)] ellipsis',
+      '1': 'block truncate',


Why did we remove ellipsis here?

is ellipsis a valid tailwind class name?

MrFlashAccount · 2025-03-05T10:33:24Z

app/gui/src/dashboard/components/Breadcrumbs/BreadcrumbItem.tsx

        data-current
        aria-current="page"
        textSelection="none"
        elementType="a"
+        icon={icon}
+        isCurrent={isCurrent}


IconDisplay isCurrent ? isDisabled ?

MrFlashAccount · 2025-03-05T10:36:59Z

app/gui/src/dashboard/pages/dashboard/Dashboard.tsx

@@ -104,14 +103,11 @@ function DashboardInner(props: DashboardProps) {
  const initialProjectName = initialLocalProjectPath != null ? null : initialProjectNameRaw

  const categoriesAPI = useCategoriesAPI()
-


Where did we move the refetch directories though?

we no longer batch refetch directories since there is no longer a tree, no? so only one directory ever needs to be refetched at any time

somebody1234 added 7 commits February 28, 2025 21:55

[dashboard/ProjectExecutionsCalendar] Fix missing key

0d26d21

[dashboard] Replace gap-icon-with-text with gap-2

f8043d0

[dashboard/AssetsTable] Add background to "hidden columns" tray

b5ee64e

Minor formatting change

951807d

Fix sort arrow in "name" and "modified" being on a separate name

b3dabf4

Format Button/types.ts

673b887

[dashboard/Button] Replace import * with import {}

dc6ed86

somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. --bug Type: bug g-dashboard labels Mar 3, 2025

somebody1234 requested review from PabloBuchu, indiv0, MrFlashAccount, Frizi, farmaazon, vitvakatu, kazcw and AdRiley as code owners March 3, 2025 08:18

somebody1234 changed the title ~~Wip/sb/flat assets fixes~~ Fix Drive table Mar 3, 2025

[dashboard/Breadcrumbs] Format

4938880

somebody1234 added 2 commits March 3, 2025 18:35

[dashboard/Drive] Infinite staleTime for root directory and parent …

532930e

…directory

[dashboard/Drive] Remove incorrect staleTime from "list directories…

c1b7331

…" calls and replace with `refetchInterval` when necessary

MrFlashAccount reviewed Mar 3, 2025

View reviewed changes

app/gui/src/dashboard/components/AriaComponents/Button/Button.tsx Outdated Show resolved Hide resolved

MrFlashAccount requested changes Mar 3, 2025

View reviewed changes

app/gui/src/dashboard/components/Breadcrumbs/Breadcrumbs.tsx Show resolved Hide resolved

app/gui/src/dashboard/components/dashboard/columnHeading/ModifiedColumnHeading.tsx Outdated Show resolved Hide resolved

somebody1234 added 4 commits March 3, 2025 21:08

[dashboard] Replace column sort icons with Icons

5ec659a

[dashboard/Button] Remove unnecessary weight prop from Button

65188bf

[dashboard/DatePicker] Fix reset button placement

81209bb

[dashboard/DatePicker] Fix foreign placeholders (visible in "Activity…

e7c04af

… Log" settings page)

[dashboard] Fix margin to the left of short icons

85a9bb9

somebody1234 requested a review from MrFlashAccount March 3, 2025 11:33

MrFlashAccount reviewed Mar 3, 2025

View reviewed changes

somebody1234 added 14 commits March 3, 2025 21:48

[dashboard] Allow destructive code actions for "organize imports" Pre…

e3ca1e7

…ttier plugin to allow automatically removing unused imports

[dashboard] Prettier + refactor imports

5e59056

[dashboard] Remove <Text /> wrapper for button content

7ae9d02

[dashboard/DatePicker] Fix segments always showing as placeholders

cfd6a5e

[dashboard/ProjectExecution] Add truncated text and hover tooltip back

c6e79bd

[dashboard/ProjectExecutionsCalendar] Avoid fading out date numbers i…

8f50c31

…n this month

[project-view] Prettier

ef51cb2

[dashboard/ProjectExecution] Show date instead of "Does not repeat" i…

a95b150

…n execution info

Merge branch 'develop' into wip/sb/flat-assets-fixes

f3f1aa6

[dashboard/IconDisplay] Add and use component

438c4f3

Merge branch 'develop' into wip/sb/flat-assets-fixes

2c3b1f2

[dashboard/IconDisplay] Fix tooltips

cab3917

[dashboard/IconDisplay] Add stories

b40c8c9

[dashboard/IconDisplay] Fix stories

e68c8b1

somebody1234 requested a review from MrFlashAccount March 5, 2025 10:26

MrFlashAccount reviewed Mar 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Drive table #12397

Fix Drive table #12397

somebody1234 commented Mar 3, 2025

github-actions bot commented Mar 3, 2025 •

edited

Loading

PabloBuchu commented Mar 3, 2025

MrFlashAccount Mar 3, 2025 •

edited

Loading

somebody1234 Mar 3, 2025

somebody1234 Mar 3, 2025

MrFlashAccount Mar 3, 2025 •

edited

Loading

somebody1234 Mar 3, 2025

MrFlashAccount Mar 3, 2025 •

edited

Loading

MrFlashAccount Mar 5, 2025

somebody1234 Mar 5, 2025

MrFlashAccount Mar 5, 2025

somebody1234 Mar 5, 2025 •

edited

Loading

MrFlashAccount Mar 5, 2025

somebody1234 Mar 5, 2025

MrFlashAccount Mar 5, 2025

MrFlashAccount Mar 5, 2025

somebody1234 Mar 5, 2025

		@@ -104,14 +103,11 @@ function DashboardInner(props: DashboardProps) {
		const initialProjectName = initialLocalProjectPath != null ? null : initialProjectNameRaw

		const categoriesAPI = useCategoriesAPI()

Fix Drive table #12397

Are you sure you want to change the base?

Fix Drive table #12397

Conversation

somebody1234 commented Mar 3, 2025

Pull Request Description

Important Notes

Checklist

github-actions bot commented Mar 3, 2025 • edited Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

PabloBuchu commented Mar 3, 2025

MrFlashAccount Mar 3, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrFlashAccount Mar 3, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrFlashAccount Mar 3, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

somebody1234 Mar 5, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Mar 3, 2025 •

edited

Loading

MrFlashAccount Mar 3, 2025 •

edited

Loading

MrFlashAccount Mar 3, 2025 •

edited

Loading

MrFlashAccount Mar 3, 2025 •

edited

Loading

somebody1234 Mar 5, 2025 •

edited

Loading