-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove semi colons from html links #12404
base: develop
Are you sure you want to change the base?
Conversation
🧪 Storybook is successfully deployed!📊 Dashboard:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests including formatting text containing URLs that have these special characters.
Maybe I'm missing something (it seems to be working in the demo!), but this looks odd. The semicolon is part of the entity; I don't see why it would be correct to insert &
without it. The semicolons are probably breaking LINKABLE_URL_REGEX
because the regex isn't intended to match escaped text; I think the regex needs to be applied before the text transformation.
Fix for ; bug in table viz:

fix:

Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.