Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove semi colons from html links #12404

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

marthasharkey
Copy link
Contributor

@marthasharkey marthasharkey commented Mar 3, 2025

Fix for ; bug in table viz:
image

fix:
image

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@marthasharkey marthasharkey marked this pull request as ready for review March 3, 2025 18:12
Copy link

github-actions bot commented Mar 3, 2025

🧪 Storybook is successfully deployed!

📊 Dashboard:

Copy link
Contributor

@kazcw kazcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests including formatting text containing URLs that have these special characters.

Maybe I'm missing something (it seems to be working in the demo!), but this looks odd. The semicolon is part of the entity; I don't see why it would be correct to insert &amp without it. The semicolons are probably breaking LINKABLE_URL_REGEX because the regex isn't intended to match escaped text; I think the regex needs to be applied before the text transformation.

@marthasharkey marthasharkey added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 5, 2025
@marthasharkey marthasharkey requested a review from kazcw March 6, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants