Documentation editor: Code block support and block format status #12406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazcw
added
the
CI: No changelog needed
kazcw
requested review from
Frizi,
farmaazon,
vitvakatu,
AdRiley,
PabloBuchu,
indiv0,
somebody1234 and
MrFlashAccount
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
farmaazon
approved these changes
Mar 4, 2025
Comment on lines
107
to
119
| /* | ||
| { // FIXME | ||
| source: '# *Formatted header*', | ||
| expected: [ | ||
| 'Document', | ||
| [ | ||
| 'ATXHeading1', | ||
| ['HeaderMark', '# '], | ||
| ['Emphasis', ['EmphasisMark', '*'], ['EmphasisMark', '*']], | ||
| ], | ||
| ], | ||
| }, | ||
| */ |
There was a problem hiding this comment.
What is to be fixed here? Do we have a task for it?
| * selected range. | ||
| */ | ||
| export function canInsertCodeBlock(_state: EditorState): boolean { | ||
| // TODO: Disable button when the cursor is already inside an unformattable block. |
There was a problem hiding this comment.
TODO left - when we would fix that?
There was a problem hiding this comment.
Implemented a solution that covers most cases.
app/gui/src/project-view/components/MarkdownEditor/codemirror/formatting/inline.ts
Show resolved
Hide resolved
New features: - New button: Insert code block. Inserts a code block after the cursor, or converts the selected text to a code block. - Block type menu now shows current type. Bug fixes: - Fix: In a multiline block quote, the space was not included as part of the delimiter except when parsing the first line. - Fix: Fenced code block delimiters were not shown when the cursor was inside the block. - Fix: Inline formatting now respects block-formatting delimiters. - Fix: Formatting controls were enabled inside code blocks. - Fix: Inline-formatted text within list items was not rendered.
kazcw
force-pushed
the
wip/kw/docs-code-blocks
branch
from
6f72e6b to
689435b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features:
Gravacao.do.ecra.2025-03-03.as.15.45.12.mov
Bug fixes:
Fixes #11970
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.