Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Hybrid execution in Electron #12408

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Enable Hybrid execution in Electron #12408

merged 1 commit into from
Mar 4, 2025
+137 −0

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Mar 4, 2025 •
edited
Loading

Pull Request Description

related: #12198

Changelog:

  • update: enable Run locally menu option in Electron app
  • update: open Hybrid execution for internal testing

Important Notes

enso-12408-electron-hybrid.mp4

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@4e6 4e6 added g-electron GUI: electron application specific -gui labels Mar 4, 2025
@4e6 4e6 self-assigned this Mar 4, 2025
@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited by unfurl-links bot
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Mar 4, 2025
@mergify mergify bot merged commit 4d1cdfe into develop Mar 4, 2025
61 of 66 checks passed
@mergify mergify bot deleted the wip/db/electron-hybrid branch March 4, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFlashAccount MrFlashAccount MrFlashAccount approved these changes

@PabloBuchu PabloBuchu Awaiting requested review from PabloBuchu PabloBuchu is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@somebody1234 somebody1234 Awaiting requested review from somebody1234 somebody1234 is a code owner

Assignees

@4e6 4e6

Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-electron GUI: electron application specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4e6 @MrFlashAccount