Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate a number of memory leaks in tests #12414

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

hubertp
Copy link
Collaborator

@hubertp hubertp commented Mar 4, 2025

Pull Request Description

Memory usage has spin out of control recently when running our test-suite. Unnecessarily.
This change eliminates a number of leaks that haven't been properly cleaned up on test teardown.
Also closed a number of stale threads.

Important Notes

Before:
Screenshot from 2025-02-28 14-40-14

After:
Screenshot from 2025-03-04 17-43-23

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.

Memory usage has spin out of control recently when running our
test-suite. Unnecessairly.
This change eliminates a number of leaks that haven't been properly
cleaned up on test teardown.
@hubertp hubertp added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 4, 2025
Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going over tests one-by-one. We really need to schedule some time for #11683.

@hubertp hubertp added the CI: Ready to merge This PR is eligible for automatic merge label Mar 5, 2025
@mergify mergify bot merged commit 9a58260 into develop Mar 5, 2025
73 checks passed
@mergify mergify bot deleted the wip/hubert/11683-memory-usage branch March 5, 2025 13:32
@enso-bot
Copy link

enso-bot bot commented Mar 7, 2025

Hubert Plociniczak reports a new STANDUP for the provided date (2025-03-04):

Progress: Merged fixes for reported NI issues. Profiling test suite and fixing performance issues to reduce CI failures. More testing of NI. It should be finished by 2025-03-05.

Next Day: Next day I will be working on the #12414 task. Continue investigating test suite perf degradation.

@enso-bot
Copy link

enso-bot bot commented Mar 7, 2025

Hubert Plociniczak reports a new STANDUP for the provided date (2025-03-05):

Progress: Finished perf improvements to our test suite. More testing of NI. Sync regarding telemetry blockers. Did some cleanup in our sbt build #12419. Tried to enable NI in staging. It should be finished by 2025-03-05.

Next Day: Next day I will be working on the #12414 task. Investigate staging issues.

@JaroslavTulach
Copy link
Member

Thanks for going over tests one-by-one. We really need to schedule some time for #11683.

It's just about applying this patch - then setup and teardown would be centralized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants