Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable running unit tests in shared packages #12427

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Re-enable running unit tests in shared packages #12427

merged 1 commit into from
Mar 6, 2025

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Mar 6, 2025 •
edited
Loading

It seems some of our unit tests have not been run in CI for some time. Re-enable running unit tests in enso-common, ydoc-server, ydoc-shared.

Fix a markdown serialization bug caught by tests that weren't being run. Disable projectExecution tests that are currently failing--tracked in #12426.

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@kazcw
Re-enable running unit tests in enso-common, ydoc-server, ydoc-shared.
852eb6c 
Fix some markdown serialization bug caught by tests that weren't being run.
Disable `projectExecution` tests that are failing.
@kazcw kazcw changed the title Re-enable running unit tests in enso-common, ydoc-server, ydoc-shared. Re-enable running unit tests in shared packages Mar 6, 2025
@kazcw kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited by unfurl-links bot
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

@kazcw kazcw marked this pull request as ready for review March 6, 2025 15:33
@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Mar 6, 2025
@mergify mergify bot merged commit a526b2b into develop Mar 6, 2025
61 of 64 checks passed
@mergify mergify bot deleted the wip/kw/ci-unit-tests branch March 6, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farmaazon farmaazon farmaazon approved these changes

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@PabloBuchu PabloBuchu Awaiting requested review from PabloBuchu PabloBuchu is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@somebody1234 somebody1234 Awaiting requested review from somebody1234 somebody1234 is a code owner

@MrFlashAccount MrFlashAccount Awaiting requested review from MrFlashAccount MrFlashAccount is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazcw @farmaazon