enso-org · mergify · Mar 10, 2025 · Mar 6, 2025 · Mar 6, 2025 · Mar 6, 2025
@@ -211,7 +211,6 @@
   "startTrial": "Start Trial",
   "trialDescription": "Start a $0-day free trial",
   "downgradeDescription": "Looking for downgrade options?",
-  "settings": "Settings",
   "cloud": "Cloud",
   "local": "Local",
   "category": "Category",
@@ -262,7 +261,7 @@
   "logs": "Logs",
   "showLogs": "Show Logs",
   "executions": "Executions",
-  "executionsCalendar": "Executions Calendar",
+  "executionsCalendar": "Scheduler",
   "accept": "Accept",
   "decline": "Decline",
   "clearTrash": "Clear Trash",
@@ -356,9 +355,11 @@
   "newFolder": "New Folder",
   "newProject": "New Project",
   "uploadFiles": "Import",
-  "downloadFiles": "Download",
+  "downloadFiles": "Export",
   "newDatalink": "New Datalink",
+  "newDatalinkOnlyCloud": "New Datalink - only available in the cloud",
   "newSecret": "New Secret",
+  "newSecretOnlyCloud": "New Secret - only available in the cloud",
   "newLabel": "New Label",
   "newEmptyProject": "New Project",
 
@@ -815,7 +816,6 @@
   "uploadToCloudShortcut": "Upload to Cloud",
   "renameShortcut": "Rename",
   "editShortcut": "Edit",
-  "editDescriptionShortcut": "Edit Description",
   "snapshotShortcut": "Snapshot",
   "deleteShortcut": "Delete",
   "undeleteShortcut": "Restore From Trash",

@@ -31,21 +31,6 @@ function locateEditingCross(page: Locator) {
   return page.getByLabel(TEXT.cancelEdit)
 }
 
-test('edit name (double click)', ({ page }) =>
-  mockAllAndLogin({ page })
-    .createFolder()
-    .driveTable.withRows(async (rows, _, { api }) => {
-      const row = rows.nth(0)
-      const nameEl = locateAssetRowName(row)
-      await nameEl.click()
-      await nameEl.click()
-      await locateInput(nameEl).fill(NEW_NAME)
-      const calls = api.trackCalls()
-      await locateEditingTick(row).click()
-      await expect(row).toHaveText(new RegExp('^' + NEW_NAME))
-      expect(calls.updateDirectory).toMatchObject([{ title: NEW_NAME }])
-    }))
-
 test('edit name (context menu)', ({ page }) =>
   mockAllAndLogin({ page })
     .createFolder()
@@ -83,15 +68,17 @@ test('edit name (keyboard)', ({ page }) =>
       expect(calls.updateDirectory).toMatchObject([{ title: NEW_NAME_2 }])
     }))
 
-test('cancel editing name (double click)', ({ page }) =>
+test('cancel editing name (context menu)', ({ page }) =>
   mockAllAndLogin({ page })
     .createFolder()
     .driveTable.withRows(async (rows, _, { api }) => {
       const row = rows.nth(0)
       const nameEl = locateAssetRowName(row)
       const oldName = (await nameEl.textContent()) ?? ''
-      await nameEl.click()
-      await nameEl.click()
+      await nameEl.click({ button: 'right' })
+      await locateContextMenu(page)
+        .getByText(/Rename/)
+        .click()
       await nameEl.getByTestId('input').fill(NEW_NAME)
       const calls = api.trackCalls()
       await locateEditingCross(row).click()
@@ -119,15 +106,17 @@ test('cancel editing name (keyboard)', ({ page }) => {
     })
 })
 
-test('change to blank name (double click)', ({ page }) =>
+test('change to blank name (context menu)', ({ page }) =>
   mockAllAndLogin({ page })
     .createFolder()
     .driveTable.withRows(async (rows, _, { api }) => {
       const row = rows.nth(0)
       const nameEl = locateAssetRowName(row)
       const oldName = (await nameEl.textContent()) ?? ''
-      await nameEl.click()
-      await nameEl.click()
+      await nameEl.click({ button: 'right' })
+      await locateContextMenu(page)
+        .getByText(/Rename/)
+        .click()
       await nameEl.getByTestId('input').fill('')
       await expect(locateEditingTick(row)).toBeVisible()
       const calls = api.trackCalls()
@@ -167,8 +156,10 @@ test('edit name, error message is visible', ({ page }) => {
     await locateAssetRowName(row).click()
 
     const nameEl = locateAssetRowName(row)
-    await nameEl.click()
-    await nameEl.click()
+    await nameEl.click({ button: 'right' })
+    await locateContextMenu(page)
+      .getByText(/Rename/)
+      .click()
 
     const inputEl = locateInput(nameEl)
 
@@ -205,8 +196,10 @@ test('edit name (empty name)', ({ page }) =>
     await locateAssetRowName(row).click()
 
     const nameEl = locateAssetRowName(row)
-    await nameEl.click()
-    await nameEl.click()
+    await nameEl.click({ button: 'right' })
+    await locateContextMenu(page)
+      .getByText(/Rename/)
+      .click()
 
     const inputEl = locateInput(nameEl)
 
@@ -242,8 +235,10 @@ test('edit name (invalid name)', ({ page }) =>
     await locateAssetRowName(row).click()
 
     const nameEl = locateAssetRowName(row)
-    await nameEl.click()
-    await nameEl.click()
+    await nameEl.click({ button: 'right' })
+    await locateContextMenu(page)
+      .getByText(/Rename/)
+      .click()
 
     const inputEl = locateInput(nameEl)
 
@@ -280,8 +275,10 @@ test('edit name (duplicate name)', ({ page }) =>
     await locateAssetRowName(row).click()
 
     const nameEl = locateAssetRowName(row)
-    await nameEl.click()
-    await nameEl.click()
+    await nameEl.click({ button: 'right' })
+    await locateContextMenu(page)
+      .getByText(/Rename/)
+      .click()
 
     const inputEl = locateInput(nameEl)
 
@@ -312,8 +309,10 @@ test('error should not overlay the table header', ({ page }) =>
     await locateAssetRowName(row).click()
 
     const nameEl = locateAssetRowName(row)
-    await nameEl.click()
-    await nameEl.click()
+    await nameEl.click({ button: 'right' })
+    await locateContextMenu(page)
+      .getByText(/Rename/)
+      .click()
 
     const inputEl = locateInput(nameEl)
 

@@ -156,7 +156,7 @@ export default defineConfig({
       },
       command: `corepack pnpm build && corepack pnpm exec vite preview --port ${ports.projectView} --strictPort`,
       // Build from scratch apparently can take a while on CI machines.
-      timeout: 240 * 1000,
+      timeout: 480 * 1000,
       port: ports.projectView,
       // We use our special, mocked version of server, thus do not want to re-use user's one.
       reuseExistingServer: false,
@@ -165,8 +165,8 @@ export default defineConfig({
       command:
         isCI || isProd ?
           `corepack pnpm exec vite -c vite.test.config.ts build && vite -c vite.test.config.ts preview --port ${ports.dashboard} --strictPort`
-        : `NODE_ENV=test corepack pnpm exec vite -c vite.test.config.ts --port ${ports.dashboard}`,
-      timeout: 240 * 1000,
+        : `cross-env NODE_ENV=test corepack pnpm exec vite -c vite.test.config.ts --port ${ports.dashboard}`,
+      timeout: 480 * 1000,
       port: ports.dashboard,
       reuseExistingServer: false,
     },

@@ -48,7 +48,6 @@ export const ACTION_TO_TEXT_ID: Readonly<
   uploadToCloud: 'uploadToCloudShortcut',
   rename: 'renameShortcut',
   edit: 'editShortcut',
-  editDescription: 'editDescriptionShortcut',
   snapshot: 'snapshotShortcut',
   delete: 'deleteShortcut',
   undelete: 'undeleteShortcut',

@@ -8,7 +8,6 @@ import { useGetAssetChildren } from '#/layouts/Drive/assetsTableItemsHooks'
 import { useDriveStore, useSetCurrentDirectoryId } from '#/providers/DriveProvider'
 import { useText } from '#/providers/TextProvider'
 import { isNewTitleUnique, type DirectoryAsset } from '#/services/Backend'
-import { isSingleClick } from '#/utilities/event'
 import { merger } from '#/utilities/object'
 import { twMerge } from '#/utilities/tailwindMerge'
 import { isDirectoryNameContainInvalidCharacters } from '#/utilities/validation'
@@ -61,16 +60,6 @@ export default function DirectoryNameColumn(props: DirectoryNameColumnProps) {
           event.stopPropagation()
         }
       }}
-      onClick={(event) => {
-        if (isSingleClick(event) && driveStore.getState().selectedIds.size === 1) {
-          const [id] = driveStore.getState().selectedIds
-          if (item.id === id) {
-            event.stopPropagation()
-            setIsEditing(true)
-            return
-          }
-        }
-      }}
     >
       <Button
         icon={FolderIcon}

@@ -4,10 +4,8 @@ import EditableSpan from '#/components/EditableSpan'
 import SvgMask from '#/components/SvgMask'
 import { backendMutationOptions } from '#/hooks/backendHooks'
 import { useGetAssetChildren } from '#/layouts/Drive/assetsTableItemsHooks'
-import { useDriveStore } from '#/providers/DriveProvider'
 import { useText } from '#/providers/TextProvider'
-import { BackendType, isNewTitleUnique, type FileAsset } from '#/services/Backend'
-import { isSingleClick } from '#/utilities/event'
+import { isNewTitleUnique, type FileAsset } from '#/services/Backend'
 import { fileIcon } from '#/utilities/fileIcon'
 import { merger } from '#/utilities/object'
 import { useMutation } from '@tanstack/react-query'
@@ -25,10 +23,8 @@ export interface FileNameColumnProps extends AssetColumnProps {
 export default function FileNameColumn(props: FileNameColumnProps) {
   const { item, state, rowState, setRowState, isEditable } = props
   const { backend } = state
-  const isCloud = backend.type === BackendType.remote
 
   const getAssetChildren = useGetAssetChildren()
-  const driveStore = useDriveStore()
   const { getText } = useText()
   const updateFileMutation = useMutation(backendMutationOptions(backend, 'updateFile'))
 
@@ -51,16 +47,6 @@ export default function FileNameColumn(props: FileNameColumnProps) {
           event.stopPropagation()
         }
       }}
-      onClick={(event) => {
-        if (!isCloud && isSingleClick(event) && driveStore.getState().selectedIds.size === 1) {
-          const [id] = driveStore.getState().selectedIds
-          if (item.id === id) {
-            event.stopPropagation()
-            setIsEditing(true)
-            return
-          }
-        }
-      }}
     >
       <SvgMask src={fileIcon()} className="m-name-column-icon size-4" />
       <EditableSpan

@@ -1,7 +1,6 @@
 /** @file An interactive button indicating the status of a project. */
 import * as reactQuery from '@tanstack/react-query'
 
-import ArrowUpIcon from '#/assets/arrow_up.svg'
 import PlayIcon from '#/assets/play.svg'
 import StopIcon from '#/assets/stop.svg'
 
@@ -83,7 +82,6 @@ export default function ProjectIcon(props: ProjectIconProps) {
 
   const openProject = projectHooks.useOpenProject()
   const closeProject = projectHooks.useCloseProject()
-  const openProjectTab = projectHooks.useOpenEditor()
 
   const { user } = authProvider.useFullUserSession()
   const { getText } = textProvider.useText()
@@ -163,9 +161,6 @@ export default function ProjectIcon(props: ProjectIconProps) {
   const doCloseProject = useEventCallback(() => {
     closeProject({ ...item, type: backend.type })
   })
-  const doOpenProjectTab = useEventCallback(() => {
-    openProjectTab(item.id)
-  })
 
   const getTooltip = (defaultTooltip: string) =>
     disabledTooltip ?? userOpeningProjectTooltip ?? defaultTooltip
@@ -241,20 +236,6 @@ export default function ProjectIcon(props: ProjectIconProps) {
               )}
             />
           </div>
-
-          {!isOtherUserUsingProject && !isRunningInBackground && (
-            <ariaComponents.Button
-              size="large"
-              variant="icon"
-              extraClickZone="xsmall"
-              icon={ArrowUpIcon}
-              aria-label={getTooltip(getText('openInEditor'))}
-              isDisabled={isDisabled}
-              tooltipPlacement="right"
-              onPress={doOpenProjectTab}
-              testId="switch-to-project"
-            />
-          )}
         </div>
       )
   }

@@ -6,15 +6,9 @@ import { backendMutationOptions } from '#/hooks/backendHooks'
 import { useOpenProject } from '#/hooks/projectHooks'
 import { useGetAssetChildren } from '#/layouts/Drive/assetsTableItemsHooks'
 import { useFullUserSession } from '#/providers/AuthProvider'
-import { useDriveStore } from '#/providers/DriveProvider'
 import { useText } from '#/providers/TextProvider'
-import {
-  BackendType,
-  IS_OPENING_OR_OPENED,
-  isNewTitleUnique,
-  type ProjectAsset,
-} from '#/services/Backend'
-import { isDoubleClick, isSingleClick } from '#/utilities/event'
+import { BackendType, isNewTitleUnique, type ProjectAsset } from '#/services/Backend'
+import { isDoubleClick } from '#/utilities/event'
 import { merger } from '#/utilities/object'
 import { PERMISSION_ACTION_CAN_EXECUTE, tryFindSelfPermission } from '#/utilities/permissions'
 import { twMerge } from '#/utilities/tailwindMerge'
@@ -36,14 +30,12 @@ export default function ProjectNameColumn(props: ProjectNameColumnProps) {
   const { getText } = useText()
   const getAssetChildren = useGetAssetChildren()
 
-  const driveStore = useDriveStore()
   const doOpenProject = useOpenProject()
   const ownPermission = tryFindSelfPermission(user, item.permissions)
   // This is a workaround for a temporary bad state in the backend causing the `projectState` key
   // to be absent.
   // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
   const projectState = item.projectState ?? CLOSED_PROJECT_STATE
-  const isRunning = IS_OPENING_OR_OPENED[projectState.type]
   const canExecute =
     isEditable &&
     (backend.type === BackendType.local ||
@@ -80,17 +72,6 @@ export default function ProjectNameColumn(props: ProjectNameColumnProps) {
       onClick={(event) => {
         if (rowState.isEditingName || isOtherUserUsingProject) {
           // The project should neither be edited nor opened in these cases.
-        } else if (
-          !isRunning &&
-          isSingleClick(event) &&
-          driveStore.getState().selectedIds.size === 1
-        ) {
-          const [id] = driveStore.getState().selectedIds
-          if (item.id === id) {
-            event.stopPropagation()
-            setIsEditing(true)
-            return
-          }
         } else if (isDoubleClick(event) && canExecute) {
           doOpenProject({
             id: item.id,

@@ -7,11 +7,10 @@ import { backendMutationOptions } from '#/hooks/backendHooks'
 import { useToastAndLog } from '#/hooks/toastAndLogHooks'
 import { useGetAssetChildren } from '#/layouts/Drive/assetsTableItemsHooks'
 import UpsertSecretModal from '#/modals/UpsertSecretModal'
-import { useDriveStore } from '#/providers/DriveProvider'
 import { useSetModal } from '#/providers/ModalProvider'
 import { useText } from '#/providers/TextProvider'
 import { isNewTitleUnique, type SecretAsset } from '#/services/Backend'
-import { isDoubleClick, isSingleClick } from '#/utilities/event'
+import { isDoubleClick } from '#/utilities/event'
 import { merger } from '#/utilities/object'
 import { useMutation } from '@tanstack/react-query'
 
@@ -28,7 +27,6 @@ export default function SecretNameColumn(props: SecretNameColumnProps) {
   const { getText } = useText()
   const { setModal } = useSetModal()
   const getAssetChildren = useGetAssetChildren()
-  const driveStore = useDriveStore()
 
   const updateSecretMutation = useMutation(backendMutationOptions(backend, 'updateSecret'))
 
@@ -52,14 +50,7 @@ export default function SecretNameColumn(props: SecretNameColumnProps) {
         }
       }}
       onClick={(event) => {
-        if (isSingleClick(event) && driveStore.getState().selectedIds.size === 1) {
-          const [id] = driveStore.getState().selectedIds
-          if (item.id === id) {
-            event.stopPropagation()
-            setIsEditing(true)
-            return
-          }
-        } else if (isDoubleClick(event) && isEditable) {
+        if (isDoubleClick(event) && isEditable) {
           event.stopPropagation()
           setModal(
             <UpsertSecretModal