Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime suggestions test for local functions #12439

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Mar 7, 2025

Pull Request Description

close #12239

Changelog:

  • add: RuntimeSuggestionUpdatesTest suite test for functions defined in Main module

Important Notes

Suggestion update with some_func method is delivered to the gui.

2025-03-06-191145_934x918_scrot
2025-03-06-191213_1020x658_scrot

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 7, 2025
@4e6 4e6 self-assigned this Mar 7, 2025
@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Mar 7, 2025
Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bug is fixed by only adding a single test? Interesting ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No suggestion entry for local function when loading the project
2 participants