Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix for the runtime docker image build following #8925 #9044

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Feb 13, 2024

Pull Request Description

Since #8925 --build-context flag must be given to build the runtime image. However, it can be used only with BuildKit.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@mwu-tow mwu-tow added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 13, 2024
@mwu-tow mwu-tow self-assigned this Feb 13, 2024
@mwu-tow mwu-tow marked this pull request as ready for review February 13, 2024 14:55
@mwu-tow mwu-tow requested review from hubertp and farmaazon February 13, 2024 14:55
@mwu-tow mwu-tow added the CI: Ready to merge This PR is eligible for automatic merge label Feb 13, 2024
@mergify mergify bot merged commit 64490ec into develop Feb 13, 2024
45 of 48 checks passed
@mergify mergify bot deleted the wip/mwu/engine-docker-build-fix branch February 13, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants