Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix area select regression #9197

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

farmaazon
Copy link
Contributor

Pull Request Description

Fixes #9182

Now we are careful when to handle events - before or after updating intersected set.

Added general E2E and detailed unit tests for selecting.

Also discovered, that sometimes the test are running while nodes are not yet in right positions. Added an instruction ensuring the position is right.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • [ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@farmaazon farmaazon added CI: No changelog needed Do not require a changelog entry for this PR. --bug Type: bug --regression Important: regression -gui labels Feb 27, 2024
@farmaazon farmaazon self-assigned this Feb 27, 2024
@kazcw kazcw mentioned this pull request Feb 28, 2024
5 tasks
@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Feb 28, 2024
This reverts commit ae9d094.
@mergify mergify bot merged commit c69ba4e into develop Feb 28, 2024
26 of 28 checks passed
@mergify mergify bot deleted the wip/farmaazon/fix-area-selecting branch February 28, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug --regression Important: regression -gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Area-selection nodes is not working.
2 participants