-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ~/.enso/credentials file #9287
Update ~/.enso/credentials file #9287
Conversation
5feea79
to
c2f6dcf
Compare
distribution/lib/Standard/Base/0.0.0-dev/src/Enso_Cloud/Internal/Utils.enso
Show resolved
Hide resolved
126d4d2
to
5e3335f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly nits
|
||
const expireAt = (() => { | ||
const date = new Date(0) | ||
date.setUTCSeconds(expirationTimestamp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference between this and new Date(expirationTimestamp * 1_000)
btw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result is the same, just used to write that way. Not sure which solution is better though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably subjective, the main differences would be the added line and the function call statement (as opposed to a function call expression)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA ✅
~/.enso/credentials
exists and contains the correct keys~/.enso/credentials
is deleted when signing out
I'm assuming testing isn't strictly necessary on other OSes as this is just modifying existing functionality - but of course it doesn't hurt to test on other platforms
4594e3e
to
16e76fa
Compare
16e76fa
to
63622f7
Compare
Pull Request Description
This PR updates the content of
~/.enso/credentials
file, where we store jwt token.Now the content would look like this:
Closes: enso-org/cloud-v2#934
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.