Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove File from File./ #9330

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Remove File from File./ #9330

merged 3 commits into from
Mar 11, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Mar 8, 2024

Pull Request Description

Closes #8905

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@AdRiley AdRiley marked this pull request as ready for review March 8, 2024 10:57
@AdRiley AdRiley added the CI: Ready to merge This PR is eligible for automatic merge label Mar 8, 2024
@AdRiley AdRiley force-pushed the wip/adr/make-file-only-accept-text branch from e021a67 to 7f89561 Compare March 11, 2024 09:24
@mergify mergify bot merged commit 8e1bb16 into develop Mar 11, 2024
32 of 34 checks passed
@mergify mergify bot deleted the wip/adr/make-file-only-accept-text branch March 11, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@Akirathan Akirathan Akirathan approved these changes

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees
No one assigned
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make File./ only accept Text
5 participants
@AdRiley @radeusgd @jdunkerley @Akirathan @JaroslavTulach