Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xml.write tests and .write to XML_Element #9332

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Mar 8, 2024

Pull Request Description

Closes #8413 . Adds tests for writing XML. Adds write to XML_Element

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 8, 2024
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny adjustment suggested.

@AdRiley AdRiley merged commit cd4a6d4 into develop Mar 11, 2024
33 of 35 checks passed
@AdRiley AdRiley deleted the wip/adr/add-xml-write-tests branch March 11, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to write a Table in XML format
3 participants