Skip to content

Make test failure source locations lazy (#12260) #2496

Make test failure source locations lazy (#12260)

Make test failure source locations lazy (#12260) #2496

GitHub Actions / Standard Library Tests Report (GraalVM CE, linux, amd64) succeeded Mar 7, 2025 in 1s

11111 passed, 0 failed and 284 skipped

Tests passed successfully

Report Passed Failed Skipped Time
/runner/_work/enso/enso/target/test-results/AWS_Tests/JUnit.xml 108✅ 21⚪ 388s
/runner/_work/enso/enso/target/test-results/Base_Internal_Tests/JUnit.xml 35✅ 4s
/runner/_work/enso/enso/target/test-results/Base_Tests/JUnit.xml 3062✅ 42⚪ 125s
/runner/_work/enso/enso/target/test-results/Examples_Tests/JUnit.xml 34✅ 58s
/runner/_work/enso/enso/target/test-results/Generic_JDBC_Tests/JUnit.xml 22✅ 1s
/runner/_work/enso/enso/target/test-results/Geo_Tests/JUnit.xml 5✅ 384ms
/runner/_work/enso/enso/target/test-results/Image_Tests/JUnit.xml 174✅ 1⚪ 1s
/runner/_work/enso/enso/target/test-results/Microsoft_Tests/JUnit.xml 604✅ 51⚪ 53s
/runner/_work/enso/enso/target/test-results/Snowflake_Tests/JUnit.xml 1⚪ 0ms
/runner/_work/enso/enso/target/test-results/Table_Internal_Tests/JUnit.xml 1✅ 765ms
/runner/_work/enso/enso/target/test-results/Table_Tests/JUnit.xml 6956✅ 167⚪ 637s
/runner/_work/enso/enso/target/test-results/Tableau_Tests/JUnit.xml 13✅ 1s
/runner/_work/enso/enso/target/test-results/Test_Tests/JUnit.xml 16✅ 2s
/runner/_work/enso/enso/target/test-results/Visualization_Tests/JUnit.xml 81✅ 1⚪ 9s

✅ /runner/_work/enso/enso/target/test-results/AWS_Tests/JUnit.xml

129 tests were completed in 388s with 108 passed, 0 failed and 21 skipped.

Test suite Passed Failed Skipped Time
(Enso Cloud -> Enso Cloud) copying/moving 1⚪ 0ms
(Enso Cloud -> Enso Cloud) Data Link copying/moving 1⚪ 0ms
(Enso Cloud -> Local) copying/moving 1⚪ 0ms
(Enso Cloud -> Local) Data Link copying/moving 1⚪ 0ms
(Enso Cloud -> S3) copying/moving 1⚪ 0ms
(Enso Cloud -> S3) Data Link copying/moving 1⚪ 0ms
(Local -> Enso Cloud) copying/moving 1⚪ 0ms
(Local -> Enso Cloud) Data Link copying/moving 1⚪ 0ms
(Local -> Local) copying/moving 5✅ 174ms
(Local -> Local) Data Link copying/moving 3✅ 1s
(Local -> S3) copying/moving 5✅ 13s
(Local -> S3) Data Link copying/moving 3✅ 18s
(S3 -> Enso Cloud) copying/moving 1⚪ 0ms
(S3 -> Enso Cloud) Data Link copying/moving 1⚪ 0ms
(S3 -> Local) copying/moving 5✅ 13s
(S3 -> Local) Data Link copying/moving 3✅ 18s
(S3 -> S3) copying/moving 5✅ 22s
(S3 -> S3) Data Link copying/moving 3✅ 42s
(S3_File) Download Mode 3✅ 27s
[Redshift] Database tests 1⚪ 0ms
AWS_Credential 4✅ 7s
DataLinks to S3_File 13✅ 10⚪ 70s
S3 Path handling 7✅ 214ms
S3_File reading 10✅ 17s
S3_File writing 21✅ 64s
S3.get_object 2✅ 12s
S3.head (bucket) 1✅ 9s
S3.head (object) 2✅ 8s
S3.list_buckets 4✅ 30s
S3.list_objects 4✅ 9s
S3.read_bucket 5✅ 9s

✅ /runner/_work/enso/enso/target/test-results/Base_Internal_Tests/JUnit.xml

35 tests were completed in 4s with 35 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
(Decimal_Constructor_Spec) conversions 1✅ 106ms
Host File values behaviour in Enso 2✅ 65ms
I/O Checks 2✅ 1s
Instrument @Tail_Call fibonacci 6✅ 1s
Instrument fibonacci 3✅ 513ms
Object Comparator 9✅ 338ms
Test Reporter running on GitHub 3✅ 304ms
Text_Utils 4✅ 195ms
to_display_text 5✅ 271ms

✅ /runner/_work/enso/enso/target/test-results/Base_Tests/JUnit.xml

3104 tests were completed in 125s with 3062 passed, 0 failed and 42 skipped.

Test suite Passed Failed Skipped Time
.to Meta.Type 2✅ 68ms
(Decimal_Spec) arithmetic 9✅ 58ms
(Decimal_Spec) BigDecimal internal representation methods 1✅ 1ms
(Decimal_Spec) comparison 12✅ 807ms
(Decimal_Spec) construction 21✅ 103ms
(Decimal_Spec) conversions 14✅ 59ms
(Decimal_Spec) Decimal.set_scale 2✅ 2ms
(Decimal_Spec) div 1✅ 6ms
(Decimal_Spec) edge cases 2✅ 26ms
(Decimal_Spec) floor, ceil, truncate 4✅ 39ms
(Decimal_Spec) Integer/Float .to_decimal 2✅ 1ms
(Decimal_Spec) min/max 3✅ 34ms
(Decimal_Spec) pow 2✅ 52ms
(Decimal_Spec) remainder 3✅ 11ms
(Decimal_Spec) Rounding 19✅ 116ms
(Decimal_Spec) signs 3✅ 4ms
(Decimal_Spec) text conversion 4✅ 45ms
(Decimal_Spec) Text.to_decimal 3✅ 10ms
(File) Download Mode 3✅ 4s
Any.map_nothing 2✅ 29ms
Any's methods 3✅ 36ms
arithmetic 1✅ 96ms
Array_Proxy 5✅ 19ms
ArrayOverBuffer 1✅ 10ms
ASCII 4✅ 140ms
Asserts 5✅ 92ms
at/get 7✅ 163ms
Atom Constructors 4✅ 16ms
Atom with holes 9✅ 126ms
Auto_Detect 3✅ 43ms
Autoscoped Constructors 20✅ 79ms
Base_64 3✅ 70ms
BigInts 26✅ 2s
Booleans 6✅ 29ms
Bound 3✅ 10ms
Builder.new 11✅ 120ms
Bytes 3✅ 43ms
caching 1✅ 131ms
Callables 5✅ 22ms
Chain Multi Value 13✅ 40ms
Check Nothing and NaN 3✅ 14ms
children 2✅ 2ms
codepoints 2✅ 2ms
Compare functionality with Vector 1✅ 32ms
Compile 6✅ 128ms
Complex Multi Value 3✅ 41ms
const 1✅ 0ms
Contexts and Execution Environment 4✅ 12ms
Conversion 33✅ 82ms
Convert Multi Value 5✅ 34ms
Correlation Statistics 6✅ 79ms
curry 1✅ 2ms
Data.read / File_Format 2✅ 644ms
Data.read_many 8✅ 347ms
Dataflow Errors 11✅ 62ms
Dataflow Warnings 34✅ 1s
DataLinks in Enso Cloud 1⚪ 0ms
DataLinks to Enso Cloud 1⚪ 0ms
Date 42✅ 7s
Date date part tests 8✅ 109ms
Date_Range 11✅ 601ms
Date_Time 46✅ 2⚪ 681ms
Date_Time date part tests 8✅ 14ms
Date_Time equality 2✅ 2ms
Day_Of_Week conversions 9✅ 4ms
Debug 1✅ 4ms
Default comparator 5✅ 51ms
Default Encoding 10✅ 517ms
display text 1✅ 1ms
Duration 15✅ 134ms
Empty errors 4✅ 3ms
Encoding object 4✅ 226ms
Enso Arrays 7✅ 37ms
Enso Cloud Audit Log 5✅ 739ms
Enso Cloud Authentication 5✅ 849ms
Enso Cloud Files 1⚪ 0ms
Enso Cloud Secrets 13✅ 3⚪ 3s
Enso Dictionaries 26✅ 2s
Enso Hashset 7✅ 165ms
Enso_User 2✅ 1⚪ 351ms
Enso_User - local mock integration tests 2✅ 405ms
Enso_User - offline logic tests 1✅ 103ms
Enso: Common polyglot Dictionary operations 29✅ 7s
Environment 1✅ 24ms
Equals and hash 2✅ 206ms
Escape 1✅ 2ms
fetch 11✅ 483ms
File Format 1✅ 36ms
File Operations 22✅ 1⚪ 589ms
flip 2✅ 2ms
Float.truncate 1✅ 18ms
Floats 6✅ 296ms
folder operations 9✅ 410ms
Format Detection in HTTP Fetch 3✅ 299ms
Formatting date/time values 6✅ 236ms
Fully Qualified Names 1✅ 2ms
Function Ascribed Parameters 12✅ 20ms
Functions 5✅ 28ms
Get by tag name 3✅ 47ms
Header 1✅ 6ms
Header resolution 7✅ 56ms
Headers 8✅ 307ms
Http Auth 2✅ 4s
HTTP client 4✅ 422ms
HTTP DataLink 11✅ 1s
Http Error handling 5✅ 894ms
HTTP in Data.read 5✅ 193ms
HTTP_Method parse 3✅ 18ms
HTTP_Status_Code 1✅ 19ms
identity 3✅ 1ms
Inlining Helpers 2✅ 42ms
inner / outer xml 2✅ 63ms
Input Stream 5✅ 126ms
Integer.truncate 1✅ 8ms
Integers 26✅ 615ms
Interval 7✅ 83ms
Java case of 3✅ 20ms
Java FFI 6✅ 1⚪ 54ms
Java: Common polyglot Dictionary operations 29✅ 175ms
Java/Enso Date 2✅ 18ms
JavaDate 42✅ 3s
JavaDate date part tests 8✅ 8ms
JavaLocalTime 29✅ 33ms
JavaScript Objects, Arrays & Functions 8✅ 545ms
JavaScript: Common polyglot Dictionary operations 29✅ 210ms
JavaScriptArrayWithADate 42✅ 4s
JavaScriptArrayWithADate date part tests 8✅ 32ms
JavascriptDataInArray 44✅ 4⚪ 290ms
JavascriptDataInArray date part tests 8✅ 10ms
JavascriptDate 44✅ 4⚪ 283ms
JavaScriptDate 42✅ 3s
JavascriptDate date part tests 8✅ 33ms
JavaScriptDate date part tests 8✅ 173ms
JavaZonedDateTime 46✅ 2⚪ 381ms
JavaZonedDateTime date part tests 8✅ 10ms
JavaZoneId 7✅ 10ms
JS_Object 5✅ 309ms
JSON 5✅ 83ms
JSON 1✅ 25ms
JSON Deserialization 10✅ 495ms
JSON Serialization 5✅ 181ms
JSON_Format 2✅ 111ms
Lazy 8✅ 40ms
Lazy Generator 1✅ 4ms
Lexicographic Order on Vectors 2✅ 9ms
List 32✅ 759ms
Locale 13✅ 137ms
Looping Imports 1✅ 3ms
Lowercase Methods 5✅ 10ms
Managed_Resource 5✅ 3s
Match.end 4✅ 31ms
Match.groups 2✅ 40ms
Match.named_groups 3✅ 90ms
Match.span 4✅ 54ms
Match.start 4✅ 30ms
Match.text 6✅ 484ms
Match.to_display_text 1✅ 19ms
Match.utf_16_end 4✅ 25ms
Match.utf_16_span 4✅ 49ms
Match.utf_16_start 4✅ 21ms
Maybe 5✅ 7ms
Meta-Value Inspection 5✅ 122ms
Meta-Value Manipulation 33✅ 639ms
Meta.Type.find 4✅ 37ms
Methods 1✅ 1⚪ 2ms
Missing_Argument 3✅ 82ms
Multi Value as type refinement 20✅ 4⚪ 759ms
MultiValue Conversions 11✅ 134ms
Natural Order 4✅ 185ms
No Method Errors 1✅ 12ms
No_Such_Method 4✅ 24ms
non-linear inserts 11✅ 371ms
Number Conversions 10✅ 206ms
Numbers 15✅ 564ms
Operator == 17✅ 340ms
Ordering 6✅ 40ms
Pair 1✅ 1ms
Pair - from 2-Item JavaScript Array 14✅ 201ms
Pair - from 2-Item List 14✅ 107ms
Pair - from 2-Item Vector 14✅ 175ms
Pair - from Pair.new 14✅ 173ms
Pair - from Pair.Value 14✅ 17ms
Panics 22✅ 222ms
parse 8✅ 227ms
Parsing date/time values 26✅ 1⚪ 270ms
Parsing formats 4✅ 334ms
Path Operations 10✅ 1⚪ 56ms
Pattern Matches 19✅ 60ms
Pattern.find and .find_all 8✅ 76ms
Pattern.match and .match_all 8✅ 79ms
Pattern.matches 5✅ 26ms
Pattern.replace 8✅ 221ms
Pattern.split 6✅ 46ms
Pattern.tokenize 7✅ 360ms
Period 8✅ 26ms
Plain_Text 3✅ 131ms
Polyglot 12✅ 85ms
Polyglot Argument 7✅ 11ms
Polyglot Argument with Inheritance 3✅ 7ms
Polyglot Conversion 14✅ 21ms
Polyglot hash maps 8✅ 696ms
Polyglot JS 21✅ 470ms
Polyglot keys and values 5✅ 291ms
Polyglot Operator == 7✅ 241ms
Polyglot Python 18✅ 395ms
Polyglot R 1⚪ 0ms
post 25✅ 2s
Private constructors 12✅ 21ms
Private methods 5✅ 3ms
Problem_Behavior 2✅ 29ms
Process 5✅ 182ms
Python: Common polyglot Dictionary operations 29✅ 326ms
PythonDate 1⚪ 0ms
PythonDate 43✅ 5⚪ 2s
PythonDate date part tests 8✅ 95ms
PythonLocalTime 29✅ 1s
Qualified Names 3✅ 11ms
Random 14✅ 894ms
Range 37✅ 1s
Rank Data 7✅ 33ms
Read XML 7✅ 182ms
read_bytes 5✅ 40ms
read_text 6✅ 148ms
Refs 6✅ 10ms
Regression 12✅ 53ms
ReportingStreamDecoder 6✅ 2s
ReportingStreamEncoder 8✅ 208ms
Request 10✅ 51ms
rounding 4✅ 54ms
Rounding 16✅ 441ms
should correctly evaluate documentation examples 8✅ 110ms
Sorting with multiple comparators 4✅ 2⚪ 92ms
Sorting with the default comparator 7✅ 3⚪ 277ms
Stack size 1✅ 14s
Stack traces 6✅ 1s
State 6✅ 8ms
Statistics 16✅ 509ms
Statistics - empty Vector 3✅ 8ms
Statistics - invalid input 5✅ 54ms
Statistics - invalid input 1✅ 1ms
Statistics - NaN Vector 3✅ 20ms
Statistics - Nothing Vector 3✅ 33ms
System 2✅ 5ms
tag name 1✅ 2ms
take/drop Sample non-determinism 2✅ 20ms
take/drop Sample non-determinism 2✅ 5ms
take/drop Sample non-determinism 2✅ 3ms
take/drop Sample non-determinism 2✅ 6ms
take/drop Sample non-determinism 2✅ 3ms
Temporary_File facility 6✅ 1⚪ 3s
Text - general 85✅ 14s
text contents 1✅ 0ms
Text_Sub_Range_Data 2✅ 68ms
Text.cleanse 14✅ 88ms
Text.match 6✅ 30ms
Text.Regex splitting 3✅ 14ms
Text.Regex tokenizing 2✅ 29ms
Text.Regex: find and find_all 20✅ 1⚪ 162ms
Text.replace 28✅ 229ms
Text.Span 3✅ 39ms
Text.substring 4✅ 9ms
the Self construct 6✅ 30ms
Time_Of_Day 29✅ 171ms
Type Errors 11✅ 97ms
uncurry 1✅ 1ms
Unix epoch conversion 4✅ 4ms
Unresolved symbol 1✅ 16ms
URI 22✅ 766ms
Use a slice of an array as vectors 104✅ 439ms
Use Array as vectors 104✅ 467ms
Use Array_Proxy as vectors 104✅ 362ms
Use Java ArrayList as vectors 104✅ 497ms
Use Vector as vectors 104✅ 1s
UTF_16 BigEndian 5✅ 59ms
UTF_16 LittleEndian 5✅ 54ms
UTF_8 11✅ 481ms
Vector Slicing Helpers 1✅ 19ms
Vector.build 13✅ 57ms
Vector/Array equality 9✅ 36ms
Windows 1252 4✅ 43ms
Wrapped dataflow errors 8✅ 24ms
Wrapped errors 8✅ 114ms
write operations 23✅ 1s
Write XML 4✅ 305ms
Zone 9✅ 4ms

✅ /runner/_work/enso/enso/target/test-results/Examples_Tests/JUnit.xml

34 tests were completed in 58s with 34 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Examples 32✅ 5s
Python Examples 1✅ 47s
Standard.Base Signature Checks 1✅ 7s

✅ /runner/_work/enso/enso/target/test-results/Generic_JDBC_Tests/JUnit.xml

22 tests were completed in 1s with 22 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
(H2) Generic JDBC Connection 11✅ 970ms
(H2) Generic JDBC Connection 11✅ 359ms

✅ /runner/_work/enso/enso/target/test-results/Geo_Tests/JUnit.xml

5 tests were completed in 384ms with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Geo Points 2✅ 32ms
GeoJSON to Table 3✅ 352ms

✅ /runner/_work/enso/enso/target/test-results/Image_Tests/JUnit.xml

175 tests were completed in 1s with 174 passed, 0 failed and 1 skipped.

Test suite Passed Failed Skipped Time
Data Links to Images 1⚪ 0ms
Image File_Format 2✅ 67ms
Image with 1 channel 19✅ 148ms
Image with 2 channels 19✅ 170ms
Image with 3 channels 19✅ 145ms
Image with 4 channels 19✅ 101ms
Image Write 2✅ 21ms
Image.read 9✅ 140ms
Matrix with 1 channel 21✅ 133ms
Matrix with 2 channels 21✅ 184ms
Matrix with 3 channels 21✅ 176ms
Matrix with 4 channels 21✅ 192ms
Matrix_Error 1✅ 2ms

✅ /runner/_work/enso/enso/target/test-results/Microsoft_Tests/JUnit.xml

655 tests were completed in 53s with 604 passed, 0 failed and 51 skipped.

Test suite Passed Failed Skipped Time
[SQLServer] (Nothing_Spec) between 45✅ 2s
[SQLServer] (Nothing_Spec) Comparisons 162✅ 8s
[SQLServer] (Nothing_Spec) is_nothing 9✅ 337ms
[SQLServer] (Nothing_Spec) not 1✅ 27ms
[SQLServer] (Nothing_Spec) sort 18✅ 599ms
[SQLServer] Audit Logs 3✅ 1⚪ 2s
[SQLServer] Column.map 1✅ 28ms
[SQLServer] Column.Offset does not work in database 1✅ 2ms
[SQLServer] Column.zip 1✅ 27ms
[SQLServer] Date-Time operations 20✅ 1⚪ 6s
[SQLServer] Date-Time support 3✅ 283ms
[SQLServer] Saving to Data Link 1⚪ 0ms
[SQLServer] Table.add_group_number 1✅ 98ms
[SQLServer] Table.add_row_number 1✅ 73ms
[SQLServer] Table.aggregate 3✅ 454ms
[SQLServer] Table.aggregate Concatenate 1⚪ 0ms
[SQLServer] Table.aggregate Count_Distinct 2✅ 2⚪ 2s
[SQLServer] Table.aggregate First and Last 1⚪ 0ms
[SQLServer] Table.aggregate Mode 1⚪ 0ms
[SQLServer] Table.aggregate Shortest 1⚪ 0ms
[SQLServer] Table.aggregate should be able to group on multiple fields 6✅ 7⚪ 707ms
[SQLServer] Table.aggregate should be able to group on single field 6✅ 7⚪ 853ms
[SQLServer] Table.aggregate should correctly select result types 2✅ 2⚪ 339ms
[SQLServer] Table.aggregate should merge warnings when issues computing aggregation 1⚪ 0ms
[SQLServer] Table.aggregate should not summarize empty table when grouped 6✅ 5⚪ 306ms
[SQLServer] Table.aggregate should raise warnings when there are issues 7✅ 2s
[SQLServer] Table.aggregate should raise warnings when there are issues computing aggregation 1⚪ 0ms
[SQLServer] Table.aggregate should report unsupported operations but not block other aggregations in warning mode 6✅ 740ms
[SQLServer] Table.aggregate should report warnings and errors based on types 4✅ 663ms
[SQLServer] Table.aggregate should summarize empty table 6✅ 5⚪ 355ms
[SQLServer] Table.aggregate should summarize whole table 8✅ 8⚪ 2s
[SQLServer] Table.aggregate Standard_Deviation 1✅ 180ms
[SQLServer] Table.aggregate+Expressions 2✅ 483ms
[SQLServer] Table.coalesce 8✅ 789ms
[SQLServer] Table.cross_join 1✅ 91ms
[SQLServer] Table.cross_tab 1⚪ 0ms
[SQLServer] Table.distinct 1✅ 24ms
[SQLServer] Table.filter 24✅ 3s
[SQLServer] Table.filter by an expression 4✅ 1⚪ 324ms
[SQLServer] Table.from_union 1⚪ 0ms
[SQLServer] Table.join 38✅ 6s
[SQLServer] Table.make_table_from_dictionary/vectors 2✅ 29ms
[SQLServer] Table.merge 1✅ 82ms
[SQLServer] Table.Offset handles bad inputs gracefully 8✅ 145ms
[SQLServer] Table.Offset with closest value fill strategy 8✅ 175ms
[SQLServer] Table.Offset with default fill strategy 8✅ 461ms
[SQLServer] Table.Offset with default fill strategy (Text Values) 4✅ 63ms
[SQLServer] Table.Offset with wrap around fill strategy 1✅ 208ms
[SQLServer] Table.Offset works with grouping - closest fill strategy 7✅ 158ms
[SQLServer] Table.Offset works with grouping - default fill strategy 7✅ 197ms
[SQLServer] Table.Offset works with multiple columns 7✅ 185ms
[SQLServer] Table.Offset works with multiple columns - updating in place 8✅ 166ms
[SQLServer] Table.Offset works with ordering - closest fill strategy 7✅ 208ms
[SQLServer] Table.Offset works with ordering - default fill strategy 7✅ 305ms
[SQLServer] Table.remove_columns 13✅ 306ms
[SQLServer] Table.rename_columns 26✅ 2s
[SQLServer] Table.reorder_columns 11✅ 195ms
[SQLServer] Table.reorder_columns by type 1✅ 60ms
[SQLServer] Table.replace 1✅ 71ms
[SQLServer] Table.select_columns 16✅ 452ms
[SQLServer] Table.select_columns By_Type and Table.remove_columns By_Type 2✅ 57ms
[SQLServer] Table.sort 21✅ 1s
[SQLServer] Table.sort_columns 4✅ 792ms
[SQLServer] Table.take/drop 2✅ 105ms
[SQLServer] Table.text_cleanse 1✅ 46ms
[SQLServer] Table.transpose 1⚪ 0ms
[SQLServer] Table.union 28✅ 1⚪ 4s
[SQLServer] Table.zip 1⚪ 0ms
[SQLServer] Temp column 2✅ 191ms

✅ /runner/_work/enso/enso/target/test-results/Snowflake_Tests/JUnit.xml

1 tests were completed in 0ms with 0 passed, 0 failed and 1 skipped.

Test suite Passed Failed Skipped Time
[Snowflake] Database tests 1⚪ 0ms

✅ /runner/_work/enso/enso/target/test-results/Table_Internal_Tests/JUnit.xml

1 tests were completed in 765ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Autoconstructor Instrumentation 1✅ 765ms

✅ /runner/_work/enso/enso/target/test-results/Table_Tests/JUnit.xml

7123 tests were completed in 637s with 6956 passed, 0 failed and 167 skipped.
Report exceeded GitHub limit of 65535 bytes and has been trimmed