Skip to content

Execute chromatic tests only when label is present #484

Execute chromatic tests only when label is present

Execute chromatic tests only when label is present #484

GitHub Actions / Standard Library Tests Report (GraalVM CE, linux, amd64) succeeded Mar 8, 2025 in 1s

11112 passed, 0 failed and 283 skipped

Tests passed successfully

Report Passed Failed Skipped Time
/runner/_work/enso/enso/target/test-results/AWS_Tests/JUnit.xml 108✅ 21⚪ 359s
/runner/_work/enso/enso/target/test-results/Base_Internal_Tests/JUnit.xml 35✅ 2s
/runner/_work/enso/enso/target/test-results/Base_Tests/JUnit.xml 3063✅ 41⚪ 108s
/runner/_work/enso/enso/target/test-results/Examples_Tests/JUnit.xml 34✅ 58s
/runner/_work/enso/enso/target/test-results/Generic_JDBC_Tests/JUnit.xml 22✅ 1s
/runner/_work/enso/enso/target/test-results/Geo_Tests/JUnit.xml 5✅ 405ms
/runner/_work/enso/enso/target/test-results/Image_Tests/JUnit.xml 174✅ 1⚪ 2s
/runner/_work/enso/enso/target/test-results/Microsoft_Tests/JUnit.xml 604✅ 51⚪ 36s
/runner/_work/enso/enso/target/test-results/Snowflake_Tests/JUnit.xml 1⚪ 0ms
/runner/_work/enso/enso/target/test-results/Table_Internal_Tests/JUnit.xml 1✅ 485ms
/runner/_work/enso/enso/target/test-results/Table_Tests/JUnit.xml 6956✅ 167⚪ 380s
/runner/_work/enso/enso/target/test-results/Tableau_Tests/JUnit.xml 13✅ 680ms
/runner/_work/enso/enso/target/test-results/Test_Tests/JUnit.xml 16✅ 958ms
/runner/_work/enso/enso/target/test-results/Visualization_Tests/JUnit.xml 81✅ 1⚪ 4s

✅ /runner/_work/enso/enso/target/test-results/AWS_Tests/JUnit.xml

129 tests were completed in 359s with 108 passed, 0 failed and 21 skipped.

Test suite Passed Failed Skipped Time
(Enso Cloud -> Enso Cloud) copying/moving 1⚪ 0ms
(Enso Cloud -> Enso Cloud) Data Link copying/moving 1⚪ 0ms
(Enso Cloud -> Local) copying/moving 1⚪ 0ms
(Enso Cloud -> Local) Data Link copying/moving 1⚪ 0ms
(Enso Cloud -> S3) copying/moving 1⚪ 0ms
(Enso Cloud -> S3) Data Link copying/moving 1⚪ 0ms
(Local -> Enso Cloud) copying/moving 1⚪ 0ms
(Local -> Enso Cloud) Data Link copying/moving 1⚪ 0ms
(Local -> Local) copying/moving 5✅ 99ms
(Local -> Local) Data Link copying/moving 3✅ 1s
(Local -> S3) copying/moving 5✅ 12s
(Local -> S3) Data Link copying/moving 3✅ 16s
(S3 -> Enso Cloud) copying/moving 1⚪ 0ms
(S3 -> Enso Cloud) Data Link copying/moving 1⚪ 0ms
(S3 -> Local) copying/moving 5✅ 12s
(S3 -> Local) Data Link copying/moving 3✅ 16s
(S3 -> S3) copying/moving 5✅ 20s
(S3 -> S3) Data Link copying/moving 3✅ 38s
(S3_File) Download Mode 3✅ 26s
[Redshift] Database tests 1⚪ 0ms
AWS_Credential 4✅ 7s
DataLinks to S3_File 13✅ 10⚪ 62s
S3 Path handling 7✅ 242ms
S3_File reading 10✅ 16s
S3_File writing 21✅ 59s
S3.get_object 2✅ 12s
S3.head (bucket) 1✅ 9s
S3.head (object) 2✅ 8s
S3.list_buckets 4✅ 28s
S3.list_objects 4✅ 9s
S3.read_bucket 5✅ 9s

✅ /runner/_work/enso/enso/target/test-results/Base_Internal_Tests/JUnit.xml

35 tests were completed in 2s with 35 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
(Decimal_Constructor_Spec) conversions 1✅ 45ms
Host File values behaviour in Enso 2✅ 12ms
I/O Checks 2✅ 358ms
Instrument @Tail_Call fibonacci 6✅ 546ms
Instrument fibonacci 3✅ 148ms
Object Comparator 9✅ 269ms
Test Reporter running on GitHub 3✅ 88ms
Text_Utils 4✅ 145ms
to_display_text 5✅ 59ms

✅ /runner/_work/enso/enso/target/test-results/Base_Tests/JUnit.xml

3104 tests were completed in 108s with 3063 passed, 0 failed and 41 skipped.

Test suite Passed Failed Skipped Time
.to Meta.Type 2✅ 25ms
(Decimal_Spec) arithmetic 9✅ 74ms
(Decimal_Spec) BigDecimal internal representation methods 1✅ 0ms
(Decimal_Spec) comparison 12✅ 656ms
(Decimal_Spec) construction 21✅ 64ms
(Decimal_Spec) conversions 14✅ 39ms
(Decimal_Spec) Decimal.set_scale 2✅ 1ms
(Decimal_Spec) div 1✅ 3ms
(Decimal_Spec) edge cases 2✅ 20ms
(Decimal_Spec) floor, ceil, truncate 4✅ 14ms
(Decimal_Spec) Integer/Float .to_decimal 2✅ 0ms
(Decimal_Spec) min/max 3✅ 17ms
(Decimal_Spec) pow 2✅ 19ms
(Decimal_Spec) remainder 3✅ 5ms
(Decimal_Spec) Rounding 19✅ 117ms
(Decimal_Spec) signs 3✅ 3ms
(Decimal_Spec) text conversion 4✅ 12ms
(Decimal_Spec) Text.to_decimal 3✅ 2ms
(File) Download Mode 3✅ 5s
Any.map_nothing 2✅ 29ms
Any's methods 3✅ 57ms
arithmetic 1✅ 20ms
Array_Proxy 5✅ 26ms
ArrayOverBuffer 1✅ 24ms
ASCII 4✅ 81ms
Asserts 5✅ 18ms
at/get 7✅ 119ms
Atom Constructors 4✅ 12ms
Atom with holes 9✅ 58ms
Auto_Detect 3✅ 46ms
Autoscoped Constructors 20✅ 75ms
Base_64 3✅ 86ms
BigInts 26✅ 695ms
Booleans 6✅ 35ms
Bound 3✅ 10ms
Builder.new 11✅ 106ms
Bytes 3✅ 49ms
caching 1✅ 59ms
Callables 5✅ 39ms
Chain Multi Value 13✅ 22ms
Check Nothing and NaN 3✅ 6ms
children 2✅ 1ms
codepoints 2✅ 1ms
Compare functionality with Vector 1✅ 42ms
Compile 6✅ 77ms
Complex Multi Value 3✅ 21ms
const 1✅ 0ms
Contexts and Execution Environment 4✅ 22ms
Conversion 33✅ 119ms
Convert Multi Value 5✅ 11ms
Correlation Statistics 6✅ 85ms
curry 1✅ 3ms
Data.read / File_Format 2✅ 577ms
Data.read_many 8✅ 828ms
Dataflow Errors 11✅ 47ms
Dataflow Warnings 34✅ 2s
DataLinks in Enso Cloud 1⚪ 0ms
DataLinks to Enso Cloud 1⚪ 0ms
Date 42✅ 9s
Date date part tests 8✅ 69ms
Date_Range 11✅ 416ms
Date_Time 46✅ 2⚪ 719ms
Date_Time date part tests 8✅ 7ms
Date_Time equality 2✅ 3ms
Day_Of_Week conversions 9✅ 12ms
Debug 1✅ 2ms
Default comparator 5✅ 36ms
Default Encoding 10✅ 255ms
display text 1✅ 1ms
Duration 15✅ 212ms
Empty errors 4✅ 5ms
Encoding object 4✅ 94ms
Enso Arrays 7✅ 61ms
Enso Cloud Audit Log 5✅ 729ms
Enso Cloud Authentication 5✅ 561ms
Enso Cloud Files 1⚪ 0ms
Enso Cloud Secrets 13✅ 3⚪ 3s
Enso Dictionaries 26✅ 550ms
Enso Hashset 7✅ 86ms
Enso_User 2✅ 1⚪ 268ms
Enso_User - local mock integration tests 2✅ 214ms
Enso_User - offline logic tests 1✅ 80ms
Enso: Common polyglot Dictionary operations 29✅ 8s
Environment 1✅ 23ms
Equals and hash 2✅ 108ms
Escape 1✅ 6ms
fetch 11✅ 2s
File Format 1✅ 33ms
File Operations 22✅ 1⚪ 2s
flip 2✅ 1ms
Float.truncate 1✅ 11ms
Floats 6✅ 81ms
folder operations 9✅ 927ms
Format Detection in HTTP Fetch 3✅ 235ms
Formatting date/time values 6✅ 263ms
Fully Qualified Names 1✅ 2ms
Function Ascribed Parameters 12✅ 7ms
Functions 5✅ 19ms
Get by tag name 3✅ 27ms
Header 1✅ 24ms
Header resolution 7✅ 65ms
Headers 8✅ 575ms
Http Auth 2✅ 4s
HTTP client 4✅ 832ms
HTTP DataLink 11✅ 2s
Http Error handling 5✅ 1s
HTTP in Data.read 5✅ 481ms
HTTP_Method parse 3✅ 12ms
HTTP_Status_Code 1✅ 11ms
identity 3✅ 2ms
Inlining Helpers 2✅ 23ms
inner / outer xml 2✅ 19ms
Input Stream 5✅ 209ms
Integer.truncate 1✅ 2ms
Integers 26✅ 359ms
Interval 7✅ 98ms
Java case of 3✅ 10ms
Java FFI 6✅ 1⚪ 45ms
Java: Common polyglot Dictionary operations 29✅ 206ms
Java/Enso Date 2✅ 36ms
JavaDate 42✅ 2s
JavaDate date part tests 8✅ 4ms
JavaLocalTime 29✅ 64ms
JavaScript Objects, Arrays & Functions 8✅ 564ms
JavaScript: Common polyglot Dictionary operations 29✅ 567ms
JavaScriptArrayWithADate 42✅ 1s
JavaScriptArrayWithADate date part tests 8✅ 15ms
JavascriptDataInArray 44✅ 4⚪ 202ms
JavascriptDataInArray date part tests 8✅ 23ms
JavascriptDate 44✅ 4⚪ 285ms
JavaScriptDate 42✅ 2s
JavascriptDate date part tests 8✅ 9ms
JavaScriptDate date part tests 8✅ 93ms
JavaZonedDateTime 46✅ 2⚪ 181ms
JavaZonedDateTime date part tests 8✅ 7ms
JavaZoneId 7✅ 9ms
JS_Object 5✅ 279ms
JSON 5✅ 91ms
JSON 1✅ 30ms
JSON Deserialization 10✅ 422ms
JSON Serialization 5✅ 207ms
JSON_Format 2✅ 362ms
Lazy 8✅ 23ms
Lazy Generator 1✅ 2ms
Lexicographic Order on Vectors 2✅ 11ms
List 32✅ 614ms
Locale 13✅ 174ms
Looping Imports 1✅ 3ms
Lowercase Methods 5✅ 7ms
Managed_Resource 5✅ 3s
Match.end 4✅ 29ms
Match.groups 2✅ 18ms
Match.named_groups 3✅ 45ms
Match.span 4✅ 40ms
Match.start 4✅ 30ms
Match.text 6✅ 69ms
Match.to_display_text 1✅ 8ms
Match.utf_16_end 4✅ 25ms
Match.utf_16_span 4✅ 53ms
Match.utf_16_start 4✅ 28ms
Maybe 5✅ 7ms
Meta-Value Inspection 5✅ 74ms
Meta-Value Manipulation 33✅ 337ms
Meta.Type.find 4✅ 38ms
Methods 1✅ 1⚪ 2ms
Missing_Argument 3✅ 33ms
Multi Value as type refinement 21✅ 3⚪ 213ms
MultiValue Conversions 11✅ 151ms
Natural Order 4✅ 158ms
No Method Errors 1✅ 9ms
No_Such_Method 4✅ 25ms
non-linear inserts 11✅ 215ms
Number Conversions 10✅ 43ms
Numbers 15✅ 245ms
Operator == 17✅ 106ms
Ordering 6✅ 23ms
Pair 1✅ 1ms
Pair - from 2-Item JavaScript Array 14✅ 192ms
Pair - from 2-Item List 14✅ 127ms
Pair - from 2-Item Vector 14✅ 118ms
Pair - from Pair.new 14✅ 92ms
Pair - from Pair.Value 14✅ 15ms
Panics 22✅ 271ms
parse 8✅ 225ms
Parsing date/time values 26✅ 1⚪ 383ms
Parsing formats 4✅ 295ms
Path Operations 10✅ 1⚪ 230ms
Pattern Matches 19✅ 73ms
Pattern.find and .find_all 8✅ 188ms
Pattern.match and .match_all 8✅ 59ms
Pattern.matches 5✅ 22ms
Pattern.replace 8✅ 114ms
Pattern.split 6✅ 42ms
Pattern.tokenize 7✅ 385ms
Period 8✅ 19ms
Plain_Text 3✅ 259ms
Polyglot 12✅ 182ms
Polyglot Argument 7✅ 7ms
Polyglot Argument with Inheritance 3✅ 7ms
Polyglot Conversion 14✅ 15ms
Polyglot hash maps 8✅ 259ms
Polyglot JS 21✅ 308ms
Polyglot keys and values 5✅ 130ms
Polyglot Operator == 7✅ 41ms
Polyglot Python 18✅ 148ms
Polyglot R 1⚪ 0ms
post 25✅ 4s
Private constructors 12✅ 22ms
Private methods 5✅ 6ms
Problem_Behavior 2✅ 33ms
Process 5✅ 54ms
Python: Common polyglot Dictionary operations 29✅ 345ms
PythonDate 1⚪ 0ms
PythonDate 43✅ 5⚪ 2s
PythonDate date part tests 8✅ 33ms
PythonLocalTime 29✅ 836ms
Qualified Names 3✅ 4ms
Random 14✅ 951ms
Range 37✅ 1s
Rank Data 7✅ 40ms
Read XML 7✅ 166ms
read_bytes 5✅ 183ms
read_text 6✅ 482ms
Refs 6✅ 12ms
Regression 12✅ 75ms
ReportingStreamDecoder 6✅ 2s
ReportingStreamEncoder 8✅ 437ms
Request 10✅ 183ms
rounding 4✅ 38ms
Rounding 16✅ 261ms
should correctly evaluate documentation examples 8✅ 45ms
Sorting with multiple comparators 4✅ 2⚪ 76ms
Sorting with the default comparator 7✅ 3⚪ 163ms
Stack size 1✅ 5s
Stack traces 6✅ 589ms
State 6✅ 10ms
Statistics 16✅ 438ms
Statistics - empty Vector 3✅ 8ms
Statistics - invalid input 5✅ 59ms
Statistics - invalid input 1✅ 1ms
Statistics - NaN Vector 3✅ 18ms
Statistics - Nothing Vector 3✅ 22ms
System 2✅ 4ms
tag name 1✅ 1ms
take/drop Sample non-determinism 2✅ 9ms
take/drop Sample non-determinism 2✅ 12ms
take/drop Sample non-determinism 2✅ 7ms
take/drop Sample non-determinism 2✅ 7ms
take/drop Sample non-determinism 2✅ 5ms
Temporary_File facility 6✅ 1⚪ 5s
Text - general 85✅ 6s
text contents 1✅ 0ms
Text_Sub_Range_Data 2✅ 11ms
Text.cleanse 14✅ 70ms
Text.match 6✅ 22ms
Text.Regex splitting 3✅ 13ms
Text.Regex tokenizing 2✅ 20ms
Text.Regex: find and find_all 20✅ 1⚪ 184ms
Text.replace 28✅ 191ms
Text.Span 3✅ 13ms
Text.substring 4✅ 6ms
the Self construct 6✅ 10ms
Time_Of_Day 29✅ 184ms
Type Errors 11✅ 88ms
uncurry 1✅ 1ms
Unix epoch conversion 4✅ 9ms
Unresolved symbol 1✅ 6ms
URI 22✅ 515ms
Use a slice of an array as vectors 104✅ 229ms
Use Array as vectors 104✅ 561ms
Use Array_Proxy as vectors 104✅ 325ms
Use Java ArrayList as vectors 104✅ 451ms
Use Vector as vectors 104✅ 1s
UTF_16 BigEndian 5✅ 23ms
UTF_16 LittleEndian 5✅ 34ms
UTF_8 11✅ 148ms
Vector Slicing Helpers 1✅ 19ms
Vector.build 13✅ 31ms
Vector/Array equality 9✅ 8ms
Windows 1252 4✅ 23ms
Wrapped dataflow errors 8✅ 37ms
Wrapped errors 8✅ 99ms
write operations 23✅ 3s
Write XML 4✅ 378ms
Zone 9✅ 6ms

✅ /runner/_work/enso/enso/target/test-results/Examples_Tests/JUnit.xml

34 tests were completed in 58s with 34 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Examples 32✅ 5s
Python Examples 1✅ 47s
Standard.Base Signature Checks 1✅ 7s

✅ /runner/_work/enso/enso/target/test-results/Generic_JDBC_Tests/JUnit.xml

22 tests were completed in 1s with 22 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
(H2) Generic JDBC Connection 11✅ 1s
(H2) Generic JDBC Connection 11✅ 447ms

✅ /runner/_work/enso/enso/target/test-results/Geo_Tests/JUnit.xml

5 tests were completed in 405ms with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Geo Points 2✅ 35ms
GeoJSON to Table 3✅ 370ms

✅ /runner/_work/enso/enso/target/test-results/Image_Tests/JUnit.xml

175 tests were completed in 2s with 174 passed, 0 failed and 1 skipped.

Test suite Passed Failed Skipped Time
Data Links to Images 1⚪ 0ms
Image File_Format 2✅ 52ms
Image with 1 channel 19✅ 163ms
Image with 2 channels 19✅ 175ms
Image with 3 channels 19✅ 172ms
Image with 4 channels 19✅ 116ms
Image Write 2✅ 30ms
Image.read 9✅ 145ms
Matrix with 1 channel 21✅ 232ms
Matrix with 2 channels 21✅ 164ms
Matrix with 3 channels 21✅ 187ms
Matrix with 4 channels 21✅ 184ms
Matrix_Error 1✅ 6ms

✅ /runner/_work/enso/enso/target/test-results/Microsoft_Tests/JUnit.xml

655 tests were completed in 36s with 604 passed, 0 failed and 51 skipped.

Test suite Passed Failed Skipped Time
[SQLServer] (Nothing_Spec) between 45✅ 1s
[SQLServer] (Nothing_Spec) Comparisons 162✅ 5s
[SQLServer] (Nothing_Spec) is_nothing 9✅ 244ms
[SQLServer] (Nothing_Spec) not 1✅ 24ms
[SQLServer] (Nothing_Spec) sort 18✅ 346ms
[SQLServer] Audit Logs 3✅ 1⚪ 2s
[SQLServer] Column.map 1✅ 34ms
[SQLServer] Column.Offset does not work in database 1✅ 1ms
[SQLServer] Column.zip 1✅ 33ms
[SQLServer] Date-Time operations 20✅ 1⚪ 4s
[SQLServer] Date-Time support 3✅ 154ms
[SQLServer] Saving to Data Link 1⚪ 0ms
[SQLServer] Table.add_group_number 1✅ 76ms
[SQLServer] Table.add_row_number 1✅ 75ms
[SQLServer] Table.aggregate 3✅ 345ms
[SQLServer] Table.aggregate Concatenate 1⚪ 0ms
[SQLServer] Table.aggregate Count_Distinct 2✅ 2⚪ 942ms
[SQLServer] Table.aggregate First and Last 1⚪ 0ms
[SQLServer] Table.aggregate Mode 1⚪ 0ms
[SQLServer] Table.aggregate Shortest 1⚪ 0ms
[SQLServer] Table.aggregate should be able to group on multiple fields 6✅ 7⚪ 402ms
[SQLServer] Table.aggregate should be able to group on single field 6✅ 7⚪ 497ms
[SQLServer] Table.aggregate should correctly select result types 2✅ 2⚪ 308ms
[SQLServer] Table.aggregate should merge warnings when issues computing aggregation 1⚪ 0ms
[SQLServer] Table.aggregate should not summarize empty table when grouped 6✅ 5⚪ 229ms
[SQLServer] Table.aggregate should raise warnings when there are issues 7✅ 1s
[SQLServer] Table.aggregate should raise warnings when there are issues computing aggregation 1⚪ 0ms
[SQLServer] Table.aggregate should report unsupported operations but not block other aggregations in warning mode 6✅ 566ms
[SQLServer] Table.aggregate should report warnings and errors based on types 4✅ 313ms
[SQLServer] Table.aggregate should summarize empty table 6✅ 5⚪ 376ms
[SQLServer] Table.aggregate should summarize whole table 8✅ 8⚪ 2s
[SQLServer] Table.aggregate Standard_Deviation 1✅ 159ms
[SQLServer] Table.aggregate+Expressions 2✅ 285ms
[SQLServer] Table.coalesce 8✅ 460ms
[SQLServer] Table.cross_join 1✅ 49ms
[SQLServer] Table.cross_tab 1⚪ 0ms
[SQLServer] Table.distinct 1✅ 22ms
[SQLServer] Table.filter 24✅ 3s
[SQLServer] Table.filter by an expression 4✅ 1⚪ 347ms
[SQLServer] Table.from_union 1⚪ 0ms
[SQLServer] Table.join 38✅ 4s
[SQLServer] Table.make_table_from_dictionary/vectors 2✅ 33ms
[SQLServer] Table.merge 1✅ 100ms
[SQLServer] Table.Offset handles bad inputs gracefully 8✅ 103ms
[SQLServer] Table.Offset with closest value fill strategy 8✅ 131ms
[SQLServer] Table.Offset with default fill strategy 8✅ 293ms
[SQLServer] Table.Offset with default fill strategy (Text Values) 4✅ 62ms
[SQLServer] Table.Offset with wrap around fill strategy 1✅ 68ms
[SQLServer] Table.Offset works with grouping - closest fill strategy 7✅ 153ms
[SQLServer] Table.Offset works with grouping - default fill strategy 7✅ 110ms
[SQLServer] Table.Offset works with multiple columns 7✅ 120ms
[SQLServer] Table.Offset works with multiple columns - updating in place 8✅ 115ms
[SQLServer] Table.Offset works with ordering - closest fill strategy 7✅ 135ms
[SQLServer] Table.Offset works with ordering - default fill strategy 7✅ 128ms
[SQLServer] Table.remove_columns 13✅ 139ms
[SQLServer] Table.rename_columns 26✅ 1s
[SQLServer] Table.reorder_columns 11✅ 100ms
[SQLServer] Table.reorder_columns by type 1✅ 25ms
[SQLServer] Table.replace 1✅ 52ms
[SQLServer] Table.select_columns 16✅ 213ms
[SQLServer] Table.select_columns By_Type and Table.remove_columns By_Type 2✅ 58ms
[SQLServer] Table.sort 21✅ 908ms
[SQLServer] Table.sort_columns 4✅ 138ms
[SQLServer] Table.take/drop 2✅ 38ms
[SQLServer] Table.text_cleanse 1✅ 20ms
[SQLServer] Table.transpose 1⚪ 0ms
[SQLServer] Table.union 28✅ 1⚪ 3s
[SQLServer] Table.zip 1⚪ 0ms
[SQLServer] Temp column 2✅ 70ms

✅ /runner/_work/enso/enso/target/test-results/Snowflake_Tests/JUnit.xml

1 tests were completed in 0ms with 0 passed, 0 failed and 1 skipped.

Test suite Passed Failed Skipped Time
[Snowflake] Database tests 1⚪ 0ms

✅ /runner/_work/enso/enso/target/test-results/Table_Internal_Tests/JUnit.xml

1 tests were completed in 485ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Autoconstructor Instrumentation 1✅ 485ms

✅ /runner/_work/enso/enso/target/test-results/Table_Tests/JUnit.xml

7123 tests were completed in 380s with 6956 passed, 0 failed and 167 skipped.
Report exceeded GitHub limit of 65535 bytes and has been trimmed