Revert PR #354 #418
Closed
Revert PR #354 #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 8, 2021 21:27
we cannot use observe to listen to changes to an extension point anymore so we cannot use observe in this specific test modified: envisage/tests/test_plugin.py
aaronayres35
approved these changes
Jun 8, 2021
|
Thanks @aaronayres35 and @rahulporuri. We should double check that the new test in #421 passes with this PR. (Though that check can be done post-merge if we want to live a little bit dangerously.) |
Merged
|
closing in favor of #422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts PR #354 from the
maint/6.0branch. This PR seems to be the cause of the issue #417 so once this PR is merged into the maintenance branch, we will be making a bugfix release - 6.0.1.This PR also undoes a change to the plugin test case made in PR #401. Because we cannot use
observeto listen to changes in an extension point anymore, the conversion from_*_changedtoobserveneeded to be undone.Note that we aren't reverting #354 from the main branch - the issue #417 isn't being closed and it won't be closed until the issue is fixed on the main branch.