-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test egg generation more reliable #499
Conversation
Thanks for the contribution! It looks as though we've got failures on Windows; I'll investigate at some point. At a guess, there's some part of the environment that we do need to pass on for things to work on Windows. |
I dug into the Windows failures a bit last night, on a Windows VM. The tests failed for me, but not in exactly the same way as above. @swt2c Would you object to me breaking off the |
No objections here. I was planning to look into the Windows issue further myself, or perhaps I could figure out which environment variable(s) are causing problems on Debian and just remove those? It's possible the problems I'm seeing are Debian specific, as I didn't see any problems on Fedora after I switched to |
Use sys.executable instead of 'python' to generate eggs to ensure the eggs are generated for the currently running python version.
da00e5a
to
1da6104
Compare
I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
I've opened #501 for the environment variable issue. At least on Windows + EDM that's probably one that needs internal investigation. |
Uses sys.executable instead of 'python' to generate eggs to ensure the eggs are generated for the currently running python version. (cherry picked from commit 301c2ab)
Uses sys.executable instead of 'python' to generate eggs to ensure the eggs are generated for the currently running python version. (cherry picked from commit 301c2ab)
Use sys.executable instead of 'python' to generate eggs to ensure the eggs are generated for the currently running python version.
Ensure the egg generation is run with a clean environment (stray environment variables caused problems on Debian, for instance).