MAINT: Update deprecated attribute name. #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
=======================================
Coverage 36.62% 36.62%
=======================================
Files 481 481
Lines 26425 26425
Branches 3916 3916
=======================================
Hits 9679 9679
Misses 16321 16321
Partials 425 425
Continue to review full report at Codecov.
|
|
@corranwebster Quick review? |
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the deprecated
traitsattribute name intotraits_name, from the (privately imported)TraitsChangeCollector. This was renamed in enthought/traits#343.I realize that this code may be obsoleted by #447, but having one less
DeprecationWarningfor pyface end users would be a good thing, in the meantime.