Fix Traits build error on Python 3.13 #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the core test workflow to run tests on the in-development 3.13 version of Python.
mdickinson
force-pushed
the
dev/core-tests-on-py313
branch
from
41895c0 to
58d4ea8
Compare
mdickinson
changed the title
mdickinson
commented
Feb 5, 2024
| @@ -808,10 +808,18 @@ static void | |||
| has_traits_dealloc(has_traits_object *obj) | |||
| { | |||
| PyObject_GC_UnTrack(obj); | |||
| #if PY_VERSION_HEX < 0x03080000 | |||
There was a problem hiding this comment.
We can simplify this if we drop support for Python 3.7, but doing that in this PR would be unnecessarily complicated. I've opened a separate issue #1769.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the core test workflow to run tests on the in-development 3.13 version of Python, and fixes use of the now-removed
Py_TRASHCAN_SAFE_BEGIN/ENDmacros.Fixes #1765.