fix build failed #200
Open
fix build failed #200
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: silenceper <[email protected]>
manojgop
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
This fixes the following error during build. This should be merged.
echo2_config.cc:17:28: error: invalid covariant return type for 'virtual Envoy::Network::FilterFactoryCb Envoy::Server::Configuration::Echo2ConfigFactory::createFilterFactoryFromProto(const google::protobuf::Message&, Envoy::Server::Configuration::FactoryContext&)'
17 | Network::FilterFactoryCb createFilterFactoryFromProto(const Protobuf::Message&,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from echo2_config.cc:6:
external/envoy/envoy/server/filter_config.h:177:3: note: overridden function is 'virtual absl::lts_20240722::StatusOr<std::function<void(Envoy::Network::FilterManager&)> > Envoy::Server::Configuration::NamedNetworkFilterConfigFactory::createFilterFactoryFromProto(const google::protobuf::Message&, Envoy::Server::Configuration::FactoryContext&)'
177 | createFilterFactoryFromProto(const Protobuf::Message& config,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.