Handle IR Deletes #442
Merged
Handle IR Deletes #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkodg
added
area/ir
Codecov Report
@@ Coverage Diff @@
## main #442 +/- ##
==========================================
+ Coverage 60.04% 60.48% +0.43%
==========================================
Files 40 40
Lines 4337 4375 +38
==========================================
+ Hits 2604 2646 +42
+ Misses 1582 1580 -2
+ Partials 151 149 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arkodg
force-pushed
the
handle-ir-deletes
branch
2 times, most recently
from
52a799b to
f20a98b
Compare
* Add a function that computes which keys to delete in the gateway-api runner * Delete above keys from the Infra and Xds IR maps * Update infra and xds runners to trigger deletes when a delete notification is recieved. Fixes: envoyproxy#423 Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
arkodg
force-pushed
the
handle-ir-deletes
branch
from
f20a98b to
3236e16
Compare
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
LukeShu
approved these changes
Sep 28, 2022
|
telepresenceio/watchable#6 can be used in the future to improve perf since we wouldn't need to loop across the IR keys multiple times |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a function that computes which keys to delete in the gateway-api runner
Delete above keys from the Infra and Xds IR maps
Update infra and xds runners to trigger deletes when a delete notification is recieved.
Fixes: #423
Signed-off-by: Arko Dasgupta [email protected]