Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign of homepage #845

Merged
merged 34 commits into from
Feb 28, 2025
Merged

Redesign of homepage #845

merged 34 commits into from
Feb 28, 2025

Conversation

iamsherlocked1891
Copy link
Collaborator

@iamsherlocked1891 iamsherlocked1891 commented Dec 9, 2024

Rework the home page to include more information of Disco.

Before

Screenshot 2025-02-17 at 12 49 17 Screenshot 2025-02-17 at 12 49 17

After

Screen.Recording.2025-02-17.at.12.50.44.mov

Features

After discussing with @MalloryHenriet, here are some ideas to consider:

  • disco font for headings
  • only use 2-3 font size and use it consistently
    • A good body size is "Build and train"
  • center the website to make reading vertical rather than horizontal
    • "Data is never shared" should go under the heading
  • the white text on the orange button doesn't have enough contrast
    • look at color.review
  • round buttons in Disco and use Disco font
  • round the Task list tags and use slack icon colors
  • try left-aligning logo in home page
  • align "3 steps" heading with the following elements
  • make logo smallers
  • Use "Lab" and "University" headers between logos
  • change the background to dark blue for the logo section
  • Add a header and more spacing for the CTA button at the bottom of the page
  • Add outlines to the federated learning animations
  • Put give us feedback in footer
    * removing feedback form for now since it hasn't been used and we provide contact details
  • Move dark theme toggle at the bottom of the sidebar or the footer
  • Display names to the sidebar icons
  • Hover on card can only show outline, no zoom
  • make main container narrower and potentially show information in a column on the right
  • make drag and drop zone green to show it is secure and make it blue on hover

Other Changes:

  • The "Info Section" icon has been removed from the sidebar
  • Deleted unused icons and renamed icons to multi-word names to comply with Vuejs convention
  • Renamed multiple component files to multi-word names
    • Notably Testing.vue has been renamed to ModelLibrary.vue and Trainer to TrainerDashboard
  • Define webapp-wide default font size and color in App.vue
  • Define theme colors in tailwind.config.ts

@iamsherlocked1891 iamsherlocked1891 marked this pull request as ready for review January 13, 2025 21:54
Copy link
Collaborator

@tharvik tharvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work, that makes a way more pro homepage, love it!

a few comments, mostly on style, aside from the text consistency on the homepage nothing blocking

while at it, you can also remove src/assets/{gif/DiscoGIF,svg/Disco,AboutUsIcon}.vue now that it is unused

Copy link
Collaborator

@tharvik tharvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

superbe! this look super pro and very straightforward! 🤩 thanks to you both!

some nitpicking comments (I'm getting lost into reviews theses days)

@JulienVig JulienVig force-pushed the 627-homepage-remake-olena branch from cfa3a1e to ea5f750 Compare February 13, 2025 16:19
@JulienVig JulienVig requested a review from tharvik February 13, 2025 16:20
@JulienVig JulienVig force-pushed the 627-homepage-remake-olena branch 2 times, most recently from 90e46f2 to 1db378b Compare February 13, 2025 16:43
Copy link
Collaborator

@tharvik tharvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup & renamings 👌

the more I review, the more I nitpick: nothing really blocking, some nice to fix

I found some readability issues in the TrainingDashboard with the dark theme

  • the banner indicating that the training is done on a new model: very-light grey over pink
  • the labels of the graphs: black over deep blue

also, when training locally, it shows "Status: Waiting for more participants" but there isn't anyone to wait for (it not blocking as the training advances anyway)

@JulienVig JulienVig force-pushed the 627-homepage-remake-olena branch from 1db378b to ae79a8c Compare February 17, 2025 11:57
@JulienVig JulienVig force-pushed the 627-homepage-remake-olena branch from ae79a8c to 54faa53 Compare February 19, 2025 15:19
@JulienVig JulienVig force-pushed the 627-homepage-remake-olena branch from 54faa53 to 161ce29 Compare February 24, 2025 16:36
@JulienVig JulienVig force-pushed the 627-homepage-remake-olena branch from c578e98 to a6d73ca Compare February 27, 2025 11:19
@JulienVig JulienVig force-pushed the 627-homepage-remake-olena branch from a6d73ca to f8cb8ea Compare February 27, 2025 13:53
@JulienVig JulienVig merged commit a71beaf into develop Feb 28, 2025
23 checks passed
@JulienVig JulienVig deleted the 627-homepage-remake-olena branch February 28, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants