-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign of homepage #845
Redesign of homepage #845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the work, that makes a way more pro homepage, love it!
a few comments, mostly on style, aside from the text consistency on the homepage nothing blocking
while at it, you can also remove src/assets/{gif/DiscoGIF,svg/Disco,AboutUsIcon}.vue
now that it is unused
7a81490
to
cfa3a1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
superbe! this look super pro and very straightforward! 🤩 thanks to you both!
some nitpicking comments (I'm getting lost into reviews theses days)
cfa3a1e
to
ea5f750
Compare
90e46f2
to
1db378b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the cleanup & renamings 👌
the more I review, the more I nitpick: nothing really blocking, some nice to fix
I found some readability issues in the TrainingDashboard with the dark theme
- the banner indicating that the training is done on a new model: very-light grey over pink
- the labels of the graphs: black over deep blue
also, when training locally, it shows "Status: Waiting for more participants" but there isn't anyone to wait for (it not blocking as the training advances anyway)
1db378b
to
ae79a8c
Compare
ae79a8c
to
54faa53
Compare
54faa53
to
161ce29
Compare
…ts from unused style
…le on training page
c578e98
to
a6d73ca
Compare
… in two columns on wide screens
a6d73ca
to
f8cb8ea
Compare
Rework the home page to include more information of Disco.
Before
After
Screen.Recording.2025-02-17.at.12.50.44.mov
Features
After discussing with @MalloryHenriet, here are some ideas to consider:
* removing feedback form for now since it hasn't been used and we provide contact details
Other Changes:
Testing.vue
has been renamed toModelLibrary.vue
andTrainer
toTrainerDashboard