-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noe/fix profiles 0x #791
Noe/fix profiles 0x #791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code updates look good. I also tested on dev network with an account that had existing v2 conversations and groups. Names showed up as expected.
I created an issue in the RN SDK to normalize address capitalization between V2 and groups to help other who would encounter similar issues => xmtp/xmtp-react-native#498
Nice fix!
Profiles could show as 0x for 1:1 conversations
Our profiles data was a bit messed up