feat: only run chmod during cleanup if variable is set

epiccurious · Dec 16, 2023 · b26b39a · b26b39a
1 parent db3c2dd
commit b26b39a
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 16 deletions.
diff --git a/device_specific/flash_the_m5stack_core_basic b/device_specific/flash_the_m5stack_core_basic
@@ -2,10 +2,11 @@
 set -e
 
 cleanup() {
-    rm -rf -- "${temp_directory}"
-    if [ "$(stat -c '%a' "${tty_device}")" != "${initial_tty_device_permissions}" ]; then
-        sudo chmod "${initial_tty_device_permissions}" "${tty_device}"
-    fi
+  rm -rf -- "${temp_directory}"
+  if [ -n "${initial_tty_device_permissions}" ] &&
+    [ "$(stat -c '%a' "${tty_device}")" != "${initial_tty_device_permissions}" ]; then
+      sudo chmod "${initial_tty_device_permissions}" "${tty_device}"
+  fi
 }
 
 working_directory="${HOME}/Downloads/diy_jade"

diff --git a/device_specific/flash_the_m5stack_fire b/device_specific/flash_the_m5stack_fire
@@ -2,10 +2,11 @@
 set -e
 
 cleanup() {
-    rm -rf -- "${temp_directory}"
-    if [ "$(stat -c '%a' "${tty_device}")" != "${initial_tty_device_permissions}" ]; then
-        sudo chmod "${initial_tty_device_permissions}" "${tty_device}"
-    fi
+  rm -rf -- "${temp_directory}"
+  if [ -n "${initial_tty_device_permissions}" ] &&
+    [ "$(stat -c '%a' "${tty_device}")" != "${initial_tty_device_permissions}" ]; then
+      sudo chmod "${initial_tty_device_permissions}" "${tty_device}"
+  fi
 }
 
 working_directory="${HOME}/Downloads/diy_jade"

diff --git a/device_specific/flash_the_m5stack_m5stickc_plus b/device_specific/flash_the_m5stack_m5stickc_plus
@@ -2,10 +2,11 @@
 set -e
 
 cleanup() {
-    rm -rf -- "${temp_directory}"
-    if [ "$(stat -c '%a' "${tty_device}")" != "${initial_tty_device_permissions}" ]; then
-        sudo chmod "${initial_tty_device_permissions}" "${tty_device}"
-    fi
+  rm -rf -- "${temp_directory}"
+  if [ -n "${initial_tty_device_permissions}" ] &&
+    [ "$(stat -c '%a' "${tty_device}")" != "${initial_tty_device_permissions}" ]; then
+      sudo chmod "${initial_tty_device_permissions}" "${tty_device}"
+  fi
 }
 
 working_directory="${HOME}/Downloads/diy_jade"

diff --git a/device_specific/flash_the_ttgo_tdisplay b/device_specific/flash_the_ttgo_tdisplay
@@ -2,10 +2,11 @@
 set -e
 
 cleanup() {
-    rm -rf -- "${temp_directory}"
-    if [ "$(stat -c '%a' "${tty_device}")" != "${initial_tty_device_permissions}" ]; then
-        sudo chmod "${initial_tty_device_permissions}" "${tty_device}"
-    fi
+  rm -rf -- "${temp_directory}"
+  if [ -n "${initial_tty_device_permissions}" ] &&
+    [ "$(stat -c '%a' "${tty_device}")" != "${initial_tty_device_permissions}" ]; then
+      sudo chmod "${initial_tty_device_permissions}" "${tty_device}"
+  fi
 }
 
 working_directory="${HOME}/Downloads/diy_jade"