Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix#968/users page #970
Fix#968/users page #970
Changes from 17 commits
78acd79
a60bb3d
b0246f8
e41bece
9ece03e
21f957f
ea02e30
0c2215c
4252010
7f88a9c
a30b78a
92e61f9
5fa8386
f92b1b2
e794493
1d48b8e
2a93bac
18e92a0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add some more variety, maybe 10 users on repeat?
Also maybe only nice images, letters are placeholders and we don't have to cover all cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. Images are great, but when you open the page you see this:
It would be great to see this instead:
Can we maybe remove John Doe, Martin Hoff etc users without images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users without images were used in design, and I'd keep them as an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use project names.
I'm fine without objects, but the way it is right now - I can't say the page is finished. So let's make it look good in this PR, then perhaps move to objects in #984 pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean something like the list below, number is not meaningful
"NexaFlow Manager"
"OrbitTrack Suite"
"DataPulse Portal"
"InnoSight Platform"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have user role specific for project in data, but I can display projects which user a part of.