Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change if the app directory is empty #541

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

falpires
Copy link

@falpires falpires commented Feb 5, 2025

This fixes an error i was having, where this test always passed, even if the app directory was empty.

The /workspace/source/app directory is actually created by an unpack script with mkdir, so unless this creation failed, this condition would never be met, even if /workspace/source/app was empty.

Before the fix:

download-s3-blob: By _ _ __ ___ _____ root,0/0 /aws
download-s3-blob: Image amazon/aws-cli:2.13.26
download: s3://epinio/aebca871-1629-4895-8d81-898ea0909b6a to ../workspace/source/aebca871-1629-4895-8d81-898ea0909b6a
download-s3-blob: _ _ __ ___ _____ Done
unpack-blob: By _ _ __ ___ _____ root,0/0 /
unpack-blob: Image ghcr.io/epinio/epinio-unpacker:v1.11.0
unpack-blob: Tar?
unpack-blob: OK
unpack-blob: /stage-support/unpack: line 33: test: =: unary operator expected
unpack-blob: '/workspace/source/appenv/CNB_PLATFORM_API' -> '/workspace/source/env/CNB_PLATFORM_API'
unpack-blob: '/workspace/source/appenv/TEST' -> '/workspace/source/env/TEST'
unpack-blob: CNB_PLATFORM_API=0.14
unpack-blob: TEST=TEST1
unpack-blob: /workspace
unpack-blob: /workspace/source
unpack-blob: /workspace/source/appenv
unpack-blob: /workspace/source/appenv/..2025_02_05_14_24_41.3046269756
unpack-blob: /workspace/source/appenv/..2025_02_05_14_24_41.3046269756/CNB_PLATFORM_API
unpack-blob: /workspace/source/appenv/..2025_02_05_14_24_41.3046269756/TEST
unpack-blob: /workspace/source/appenv/..data
unpack-blob: /workspace/source/appenv/CNB_PLATFORM_API
unpack-blob: /workspace/source/appenv/TEST
unpack-blob: /workspace/source/app
unpack-blob: /workspace/source/env
unpack-blob: /workspace/source/env/CNB_PLATFORM_API
unpack-blob: /workspace/source/env/TEST
unpack-blob: /workspace/cache
unpack-blob: _ _ __ ___ _____ Done
buildpack: By _ _ __ ___ _____ heroku,1000/1000 /layers
buildpack: Setting registry access for Heroku builder
buildpack: /workspace
buildpack: /workspace/source
buildpack: /workspace/source/appenv
buildpack: /workspace/source/appenv/..2025_02_05_14_24_41.3046269756
buildpack: /workspace/source/appenv/..2025_02_05_14_24_41.3046269756/CNB_PLATFORM_API
buildpack: /workspace/source/appenv/..2025_02_05_14_24_41.3046269756/TEST
buildpack: /workspace/source/appenv/..data
buildpack: /workspace/source/appenv/CNB_PLATFORM_API
buildpack: /workspace/source/appenv/TEST
buildpack: /workspace/source/app
buildpack: /workspace/source/env
buildpack: /workspace/source/env/CNB_PLATFORM_API
buildpack: /workspace/source/env/TEST
buildpack: /workspace/cache

After the fix:

download-s3-blob: By _ _ __ ___ _____ root,0/0 /aws
download-s3-blob: Image amazon/aws-cli:2.13.26
download: s3://epinio/fefdcb3a-25e9-4245-bf4a-c43a03d56b20 to ../workspace/source/fefdcb3a-25e9-4245-bf4a-c43a03d56b20
download-s3-blob: _ _ __ ___ _____ Done
unpack-blob: By _ _ __ ___ _____ root,0/0 /
unpack-blob: Image ghcr.io/epinio/epinio-unpacker:v1.11.0
unpack-blob: Tar?
unpack-blob: OK
unpack-blob: /stage-support/unpack: line 33: test: =: unary operator expected
unpack-blob: '/workspace/source/appenv/CNB_PLATFORM_API' -> '/workspace/source/env/CNB_PLATFORM_API'
unpack-blob: '/workspace/source/appenv/TEST' -> '/workspace/source/env/TEST'
unpack-blob: CNB_PLATFORM_API=0.14
unpack-blob: TEST=TEST1
unpack-blob: /workspace
unpack-blob: /workspace/source
unpack-blob: /workspace/source/appenv
unpack-blob: /workspace/source/appenv/..2025_02_05_14_31_05.2796454375
unpack-blob: /workspace/source/appenv/..2025_02_05_14_31_05.2796454375/TEST
unpack-blob: /workspace/source/appenv/..2025_02_05_14_31_05.2796454375/CNB_PLATFORM_API
unpack-blob: /workspace/source/appenv/..data
unpack-blob: /workspace/source/appenv/TEST
unpack-blob: /workspace/source/appenv/CNB_PLATFORM_API
unpack-blob: /workspace/source/app
unpack-blob: /workspace/source/env
unpack-blob: /workspace/source/env/CNB_PLATFORM_API
unpack-blob: /workspace/source/env/TEST
unpack-blob: /workspace/cache
unpack-blob: /workspace/cache/committed
unpack-blob: /workspace/cache/staging
unpack-blob: _ _ __ ___ _____ Done
buildpack: By _ _ __ ___ _____ heroku,1000/1000 /layers
buildpack: Setting registry access for Heroku builder
buildpack: Nothing to build
 ›   Error: Failed to stage application: Error: Staging failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant