Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix basic scenario of built-in (embedded) extention #264

Merged
merged 6 commits into from
Jul 3, 2023
Merged

Fix basic scenario of built-in (embedded) extention #264

merged 6 commits into from
Jul 3, 2023

Conversation

richard-cox
Copy link
Member

Summary

Contributes to #192

Occurred changes and/or fixed issues

  • Run from ./dashboard via API=<rancher url> yarn mem-dev
  • This runs the normal rancher dashboard with the epinio extension 'built-in' / embedded
  • Generic creds hardcoded (currently with example username/password)

Depends on #259

@richard-cox richard-cox added this to the v1.9.0 milestone Jun 29, 2023
@richard-cox richard-cox self-assigned this Jun 29, 2023
@richard-cox richard-cox marked this pull request as draft June 29, 2023 12:28
@richard-cox richard-cox marked this pull request as ready for review June 29, 2023 13:09
@richard-cox richard-cox requested a review from torchiaf June 29, 2023 13:09
@richard-cox
Copy link
Member Author

I think i've badly merged the about page changes (it should be in the cluster context)

@richard-cox richard-cox marked this pull request as draft June 30, 2023 09:20
@richard-cox
Fix bad merge
6465d78 
- about page should be in cluster context
@richard-cox
Version required to show in side nav
e6ca5eb
@richard-cox richard-cox marked this pull request as ready for review July 3, 2023 10:21
torchiaf
torchiaf approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manager dashboard works fine. We will run a cycle of tests over embedded Epinio later.

@richard-cox richard-cox merged commit e329541 into main Jul 3, 2023
@richard-cox richard-cox deleted the fix-embedded branch July 3, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torchiaf torchiaf torchiaf approved these changes

Assignees

@richard-cox richard-cox

Labels
None yet
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @torchiaf