Fix coroutines crash with MSVC (#522) #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equeim
force-pushed
the
fix-crash
branch
2 times, most recently
from
1d89d15 to
5a1acd7
Compare
MSVC doesn't like when coroutine is destroyed inside final suspender's await_suspend(). Instead return false from it's await_ready() allowing compiler's injected code to destroy coroutine automatically. In this case we also need to make sure that out Coroutine<> object doesn't destroy coroutine automatically since it will result in double free (we call completion callback in final suspender's await_ready() which immediately destroys Coroutine<>).
equeim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.