Simplify settings properties definitions #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equeim
force-pushed
the
settings-simplification
branch
from
cfd106c to
737efee
Compare
If we call restoreGeometry() after main loop iteration, it might happen in the middle of creation of native window and be ignored. So call synchronously in constructor instead. The reason why we were doing it like that in the first place is because in Impl constructor the MainWindow::mImpl member is still uninitialized, and we use in MainWindow::event override, which may be called from restoreGeometry(). Instead use QMetaObject::invokeMethod in that override so that Impl::updateShowHideAction is called on the next iterator of event loop (this is what we should be doing anyway).
equeim
force-pushed
the
settings-simplification
branch
from
737efee to
4f53ea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.