Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXF-104025: Remove Unused Test - CloudRouter2PortRoutingProtocol #166

Closed
wants to merge 1 commit into from

Conversation

d-bhola
Copy link
Collaborator

@d-bhola d-bhola commented Feb 14, 2025

Removed test - TestCloudRouter2PortRoutingProtocolCreateConnection_DIGP

image

@thogarty
Copy link
Collaborator

@d-bhola , justification?

@d-bhola
Copy link
Collaborator Author

d-bhola commented Feb 14, 2025

@d-bhola , justification?
@thogarty - This is showing up as a failing test and its not been used.

Error Trace:	/home/runner/go/pkg/mod/github.com/gruntwork-io/[email protected]/modules/terraform/apply.go:15
        	            				/home/runner/work/terraform-equinix-fabric/terraform-equinix-fabric/tests/prod/prod_sanity_suite_test.go:213
        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: chdir ../../tests/examples-without-external-providers/cloud-router-2-port-routing-protocol-connection: no such file or directory; }
        	Test:       	TestCloudRouter2PortRoutingProtocolCreateConnection_DIGP
TestCloudRouter2PortRoutingProtocolCreateConnection_DIGP 2025-02-14T21:43:25Z retry.go:91: terraform [destroy -auto-approve -input=false -lock=false]
TestCloudRouter2PortRoutingProtocolCreateConnection_DIGP 2025-02-14T21:43:25Z logger.go:67: Running command terraform with args [destroy -auto-approve -input=false -lock=false]
TestCloudRouter2PortRoutingProtocolCreateConnection_DIGP 2025-02-14T21:43:25Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: chdir ../../tests/examples-without-external-providers/cloud-router-2-port-routing-protocol-connection: no such file or directory; }
    destroy.go:11: 
        	Error Trace:	/home/runner/go/pkg/mod/github.com/gruntwork-io/[email protected]/modules/terraform/destroy.go:11
        	            				/opt/hostedtoolcache/go/1.21.13/x64/src/runtime/panic.go:523
        	            				/opt/hostedtoolcache/go/1.21.13/x64/src/testing/testing.go:999
        	            				/home/runner/go/pkg/mod/github.com/gruntwork-io/[email protected]/modules/terraform/apply.go:15
        	            				/home/runner/work/terraform-equinix-fabric/terraform-equinix-fabric/tests/prod/prod_sanity_suite_test.go:213
        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: chdir ../../tests/examples-without-external-providers/cloud-router-2-port-routing-protocol-connection: no such file or directory; }
        	Test:       	TestCloudRouter2PortRoutingProtocolCreateConnection_DIGP

The test directory was renamed to include route filters and the test corresponding to it wasn't updated appropriately. Please update test name and path instead of removing the test.

@thogarty
Copy link
Collaborator

This fix can also be in the service keys PR. Doesn't need to be separated because it is all automated testing related.

@d-bhola
Copy link
Collaborator Author

d-bhola commented Feb 14, 2025

This fix can also be in the service keys PR. Doesn't need to be separated because it is all automated testing related.

Okay. I can add it in the same PR.

@d-bhola
Copy link
Collaborator Author

d-bhola commented Feb 14, 2025

Closing this PR . Changes added in PR - #165

@d-bhola d-bhola closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants