Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests #85

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

Integration tests #85

wants to merge 54 commits into from

Conversation

daghovland
Copy link
Contributor

@daghovland daghovland commented Feb 6, 2025

Aim of the PR

This PR fixes AB#223357

Integration tests on the C# backend of the dexpi poc

Implementation

WebApplicationFactory for running the backend in tests. Dotnet TestContainers for runing Rdfox. Some tests of package and boundaries.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • This change requires a documentation update

If the changes impact any dependent services then provide details.

How Has This Been Tested?

Ran the tests locally

Additional Changes

The RdfoxApi was made non-static and included as a service. Upgraded to dotnet 9.

@markus-ap
Copy link
Contributor

markus-ap commented Feb 6, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@daghovland daghovland marked this pull request as ready for review February 7, 2025 13:50
Copy link
Contributor

@eoye eoye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I did some minor cleanup, and also fixed the test in DatalogCreatorTests by removing whitespaces so the test doesn't fail due to different spaces and newlines. I also removed the unused Tests project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants