Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/datagrid functionality #1108

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Feature/datagrid functionality #1108

merged 4 commits into from
Jan 10, 2024

Conversation

awesthouse
Copy link
Contributor

What does this pull request change?

  • Support for allowing to disable editing in DataGrid
  • Support for custom and auto-made columnLabels and rowLabels
  • Support for hiding column and row labels
  • Support for making column and rows non-adjustable (add, delete)
  • Support for disabling moving of rows
  • Support for title and description in the DataGrid plugin
  • Support for printing data both vertically and horizontally
  • Support for passing multiple 1-dimensional primitives to DataGrid
  • Improvements to styling
  • More and better examples of use of DataGridPlugin

Why is this pull request needed?

Expand functionality of DataGridPlugin and DataGrid component

Issues related to this change

#998

@awesthouse awesthouse requested a review from a team as a code owner January 10, 2024 09:15
soofstad
soofstad approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@soofstad soofstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Rebase to get green tests 🙂

@awesthouse awesthouse force-pushed the feature/datagrid-functionality branch from 10424da to 14cd2ce Compare January 10, 2024 13:31
@awesthouse awesthouse merged commit 24e5d45 into main Jan 10, 2024
7 of 8 checks passed
@awesthouse awesthouse deleted the feature/datagrid-functionality branch January 10, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soofstad soofstad soofstad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awesthouse @soofstad