Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change XML field name in EXIT file from forward model #10020

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

berland
Copy link
Contributor

@berland berland commented Feb 10, 2025

job -> step.

Issue
Resolves naming inconsistency jobs vs step for the XML EXIT file left in the runpath.

This is potentially a breaking change.

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland changed the title Change XML field names in EXIT file from forward model Change XML field name in EXIT file from forward model Feb 10, 2025
@berland berland self-assigned this Feb 10, 2025
@berland berland added the release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI label Feb 10, 2025
Copy link

codspeed-hq bot commented Feb 10, 2025

CodSpeed Performance Report

Merging #10020 will improve performances by 11.8%

Comparing berland:job_step_in_xml (3205f61) with main (718834e)

Summary

⚡ 1 improvements
✅ 24 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_record_observations] 2.7 ms 2.4 ms +11.8%

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@berland
Copy link
Contributor Author

berland commented Feb 10, 2025

Pinging @sondreso for second opinion on user impact. Breaking?

@sondreso sondreso added the release-notes:breaking-change Automatically categorise as breaking change in release notes label Feb 10, 2025
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this counts as a breaking change yes, and we should mark it as such. But the actual impact on users should be low, so I'm in favor of merging this.

@berland berland added blocked and removed release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI labels Feb 11, 2025
@berland
Copy link
Contributor Author

berland commented Feb 11, 2025

This is blocked from merging until there is another breaking change that comes along. This is to avoid version number inflation.

@berland berland merged commit 92d1971 into equinor:main Feb 14, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked release-notes:breaking-change Automatically categorise as breaking change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants