-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin numpy #9679
base: main
Are you sure you want to change the base?
Unpin numpy #9679
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9679 +/- ##
==========================================
- Coverage 91.74% 91.73% -0.01%
==========================================
Files 430 426 -4
Lines 26639 26518 -121
==========================================
- Hits 24439 24326 -113
+ Misses 2200 2192 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #9679 will degrade performances by 14.46%Comparing Summary
Benchmarks breakdown
|
The everest tests are green because they implicitly install |
If you install ert & ropt-dakota you should get numpy<2 so is this then still blocking? |
We can merge this, but it will not imply that Ert is compatible with numpy 2 as the tests will give a false positive. |
Issue
Resolves #8570
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable